-
Notifications
You must be signed in to change notification settings - Fork 432
fix(runtime): stop estimating context fit; the provider decides, the Maka window is a user target #4574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
fix(runtime): stop estimating context fit; the provider decides, the Maka window is a user target #4574
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ee1fd21
fix(runtime): stop estimating context fit; the provider decides
Joob1n 08d1103
fix(runtime): request stream usage from every OpenAI-compatible provider
Joob1n 5a250aa
fix(runtime): end every summary request with an instruction the model…
Joob1n 0d08478
fix(runtime): show the compaction note in the turn that was compacted
Joob1n 8c88243
fix(runtime): address review on the provider-decides context budget
Joob1n 78b47b8
chore(runtime-host): move the compatibility epoch to 105
Joob1n b43ac14
fix(runtime): keep the summarizer's context-length signal through a r…
Joob1n ccf0125
test(runtime): pin the strict-relay contract for stream usage requests
Joob1n 87b9d80
fix(runtime): treat a usage plateau as provider context dropping
Joob1n 9f0408a
fix(runtime): bound the summarizer, the length fold and the dropping …
Joob1n 58fd080
feat(runtime): reserve the last real reply and report a window overrun
Joob1n bb1cc9e
feat(runtime): report a request accepted past the model's reported wi…
Joob1n a49dc06
fix(runtime): report the reported-window crossing once, not once per …
Joob1n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 38 additions & 38 deletions
76
docs/architecture/llm-compaction-events-log-projection-draft.md
Large diffs are not rendered by default.
Oops, something went wrong.
74 changes: 37 additions & 37 deletions
74
docs/architecture/llm-compaction-events-log-projection-draft.zh-CN.md
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Real edge case from live data: kimi-coding-plan/k3-256k accepts requests beyond its fetched window without rejecting or truncating — observed a session accepted at 322K input tokens against a fetched
contextWindowof 262,144, with usage still growing monotonically (305K → 322K). On such a provider every signal this design reads stays dark for an undeclared window:context_provider_droppingnever fires (and it is mid-turn only anyway);context_window_suggestiononly fires on a surfaced rejection → never written;/modelswindow is not a declaration → the proactive trigger below never arms.Net effect: an undeclared kimi session degrades silently and indefinitely (this is exactly the data behind #4634). I agree with "Maka does not decide for the user" as a principle, but for providers observed to accept over-window requests, could the fetched window seed a default declaration (user-overridable), or should the cross-turn plateau check (#4623 PR D) be a blocker rather than a follow-up?