Drop backslash escapes that Markdown does not need - #507
Open
slachiewicz wants to merge 1 commit into
Open
Conversation
Pages converted from APT with an older doxia-converter carry an escape in front of punctuation that is not markup where it stands: a hyphen or underscore inside a word, a parenthesis, a full stop after a letter. The backslash renders as nothing and only makes the source harder to read and to edit. Only positions where the bare character can never be markup are touched. A full stop after a digit keeps its escape, so an ordered list marker cannot appear by accident, and angle brackets keep theirs, since <escapeString> would otherwise be read as a tag. Code spans, fenced blocks and link destinations are left alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages converted from APT with an older
doxia-convertercarry a backslash in front ofpunctuation that is not markup where it stands, for example
maven\-source\-plugin,\(default\)andrequired\.. The backslash renders as nothing; it only makes the sourceharder to read and to edit, which was the point of moving to Markdown.
Only positions where the bare character can never be markup are touched: a hyphen,
underscore or asterisk between two word characters, a parenthesis, a full stop that
does not follow a digit, and an exclamation mark not followed by
[.Left alone deliberately:
<escapeString>really would be read as an HTML tag...is rendered as a single ellipsis characterVerified by building the site before and after: every generated page is identical in
its visible text and in every link target.