Add followSymlinks to follow links when jarring sources - #328
Merged
Conversation
slachiewicz
added
enhancement
slachiewicz
marked this pull request as ready for review
August 23, 2026 13:08
A symlink under a source root was archived as a link, so the sources jar carried an entry pointing outside itself and the linked file was absent (plexus-archiver#160). The new parameter defaults to false, keeping that behaviour for anyone relying on it. Needs plexus-archiver 4.14.0 for FileSet.isFollowingSymLinks().
slachiewicz
force-pushed
the
follow-symlinks-master
branch
from
August 24, 2026 19:36
cf27ede to
22e5858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-ports #327 to master.
Same parameter, same default of false. Two conflicts came out of the port:
addDirectorytakes aPathon this line, and the archiver version lives in the${plexusArchiverVersion}property rather than at the dependency — the property moves 4.12.0 → 4.14.0.See #327 for the bug (plexus-archiver#160) and for the verification; the ITs there cover the same code.
I have not run this line's ITs locally — the plugin declares prerequisite Maven 4.0.0-rc-6, so they need a Maven 4 to run at all. Leaving that to CI.
This change was created with AI assistance.