Conversation
…with Several service builders take reqsign types from the application: `S3::credential_provider_chain`, `Azblob::credential_provider_chain`, `Azdls::credential_provider_chain`, and the `credential_provider` and `credential_provider_chain` pair on `Gcs` and `GcsGrpc`. None of those types were reachable through OpenDAL, so an application that wants to plug in a credential provider of its own has to depend on `reqsign-core` and the matching backend crate directly, and keep its versions compatible with the ones the service was built with by hand. Re-export `reqsign_core` from `opendal-core` behind the existing `reqsign` feature, and the backend crate from each service that signs with it, so the types an application implements against are the ones the service uses. Point the docs of the seven builder methods at the re-exports.
github-actions
Bot
added
core
releases-note/feat
6 tasks
Author
|
minio tests failing due to https://www.reddit.com/r/minio/comments/1wfs5hc/minio_just_removed_their_dockerhub_image/ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8345
Rationale for this change
Several service builders take
reqsigntypes from the application, but none of those types are reachable through OpenDAL. An application that plugs in a credential provider of its own therefore has to depend onreqsign-coreand the matching backend crate directly, and keep their versions compatible with the ones the service was built with by hand.What changes are included in this PR?
opendal-corere-exportsreqsign_corebehind its existingreqsignfeature.reqsign_aws_v4from s3,reqsign_azure_storagefrom azblob and azdls,reqsign_googlefrom gcs and gcs-grpc.reqsigntypes point at the re-exports.Are there any user-facing changes?
New re-exports; no existing API changes.
Providers can now be implemented against
opendal::reqsign_coreandopendal::services::reqsign_*instead of directreqsigndependencies. No new features or dependencies are added: every signing service already depends on its backend crate and already enablesopendal-core/reqsign.Breaking changes
AI Usage Statement
if the docstrings are too verbose for your taste, i'm happy to remove them as well.