[OPENJPA-2971] Make PostgreSQL StoreCharsAsNumbers default overridable and release-note it - #163
Open
rzo1 wants to merge 1 commit into
Open
[OPENJPA-2971] Make PostgreSQL StoreCharsAsNumbers default overridable and release-note it#163rzo1 wants to merge 1 commit into
rzo1 wants to merge 1 commit into
Conversation
Since #144 PostgresDictionary.connectedConfiguration() unconditionally set storeCharsAsNumbers=false on PostgreSQL 9+, clobbering an explicit StoreCharsAsNumbers=true from the DBDictionary plugin properties (which are applied before connectedConfiguration()). Track explicit user values via a new setStoreCharsAsNumbers() setter, make native CHAR storage the PostgresDictionary default and only fall back to numeric storage on PostgreSQL < 9 when not configured explicitly. Document the new default and the opt-out in the reference guide and migration considerations; add TestPostgresDictionary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JJiFSo4QfgPaz7i5UQPREw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #144
PostgresDictionary.connectedConfiguration()unconditionally setstoreCharsAsNumbers=falseon PostgreSQL 9+. BecauseDBDictionaryFactoryapplies the user'sDBDictionaryplugin properties beforeconnectedConfiguration(), an explicitStoreCharsAsNumbers=truewas silently clobbered, breaking schemas created by earlier OpenJPA releases (char fields inINTEGERcolumns).This adds
setStoreCharsAsNumbers()/getStoreCharsAsNumbers()toDBDictionary(Optionsprefers the setter over the public field) to track an explicit user value, makes native CHAR storage thePostgresDictionaryconstructor default, and only falls back to numeric storage on PostgreSQL < 9 when nothing was configured explicitly. The public field is kept for backward compatibility.Documents the new default and the opt-out (
openjpa.jdbc.DBDictionary=postgres(StoreCharsAsNumbers=true)) in the reference guide and the JPA 3.2 migration considerations, and addsTestPostgresDictionarycovering defaults, explicit overrides via plugin properties / setter / field, andDBDictionaryFactoryend-to-end. The TCK-relevant default (CHAR columns) is unchanged.Ref: #144 (comment)