[ISSUE #150] sink support topic tag - #151
Conversation
| List<String> topicTagList = Splitter.on(COMMA).omitEmptyStrings().trimResults().splitToList(topicNameAndTagss); | ||
| Map<String, String> topicNameAndTagssMap = new HashMap<>(8); | ||
| for (String topicTagPair : topicTagList) { | ||
| List<String> topicAndTag = Splitter.on(SEMICOLON).omitEmptyStrings().trimResults().splitToList(topicTagPair); |
There was a problem hiding this comment.
IMO, exchange COMMA and SEMICOLON to maintain upgrade compatible.
There was a problem hiding this comment.
When there is no tag, if you configure multiple topics, it should be topic1, topic2, topic3. If there is a tag, it should be topic1;tag1, topic2;tag2, topic3;tag3, if so, is there no compatibility problem?
|
files conflicted. @odbozhou |
|
This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts: git fetch origin
git checkout sink_support_tag
git rebase origin/main
# resolve conflicts, then:
git push --force-with-leaseThis is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved. Automated notification by github-manager-bot |
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR modifies 2 file(s) with 76 lines of diff. No test changes detected — consider adding test coverage.
Automated review by github-manager-bot
| @@ -19,25 +19,30 @@ | |||
| package org.apache.rocketmq.connect.runtime.config; | |||
There was a problem hiding this comment.
No test changes detected alongside source modifications. Consider adding tests to cover the changes.
4 participants
What is the purpose of the change
close #150
Brief changelog
XX
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.