【ISSUE #133】RocketMQ-Operator support the rocketmq-5.0 proxy node for cluster pattern - #134
【ISSUE #133】RocketMQ-Operator support the rocketmq-5.0 proxy node for cluster pattern#134shendongsd wants to merge 6 commits into
Conversation
…q-operator into feature_proxy
caigy
left a comment
caigy
left a comment
There was a problem hiding this comment.
It seems that ClusterRole for proxy is missing.
| // INSERT ADDITIONAL SPEC FIELDS - desired state of cluster | ||
| // Important: Run "operator-sdk generate k8s" to regenerate code after modifying this file | ||
| // Add custom validation using kubebuilder tags: https://book-v1.book.kubebuilder.io/beyond_basics/generating_crd.html | ||
| ProxyStatefulSet v1.StatefulSet `json:"proxyStatefulSet"` |
There was a problem hiding this comment.
Proxy is stateless, so is deployment more appropriate than statefulset?
Furthermore, it would be more elegant that users should only provide configs which they care about, instead of providing the whole statefulset or deployment.
|
How is it going? Can you merge it? @shendongsd |
|
This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts: git fetch origin
git checkout feature_proxy
git rebase origin/main
# resolve conflicts, then:
git push --force-with-leaseThis is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved. Automated notification by github-manager-bot |
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR modifies 11 file(s) with 8682 lines of diff. No test changes detected — consider adding test coverage.
Automated review by github-manager-bot
Additional notes (not anchored to a changed line)
- [INFO]
Makefile:1— Large diff (8682 lines). Consider breaking into smaller, focused PRs for easier review. (line outside diff)
| @@ -23,6 +23,7 @@ import ( | |||
| "github.com/apache/rocketmq-operator/pkg/controller/broker" | |||
There was a problem hiding this comment.
No test changes detected alongside source modifications. Consider adding tests to cover the changes.
4 participants
What is the purpose of the change
ISSUE #133RocketMQ-Operator support the rocketmq-5.0 proxy node for cluster pattern
And I will add local pattern later