Conversation
…wExpression.hasWindowExpression
uros-b
changed the title
uros-b
commented
Sep 21, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
This should be good to go, I don't think there are any additional occurrences in sql catalyst / core
dongjoon-hyun
approved these changes
Sep 21, 2026
HyukjinKwon
approved these changes
Sep 21, 2026
Member
Author
|
Thank you @dongjoon-hyun and @HyukjinKwon! |
uros-b
added a commit
that referenced
this pull request
Sep 22, 2026
…in catalyst and SQL core ### What changes were proposed in this pull request? Several places in `catalyst` and SQL core test for a matching node/element with `find(pred)` followed by an `Option` presence check. On `TreeNode` (and Scala collections) `exists(pred)` is the equivalent, returning the `Boolean` directly. This replaces the pattern in four spots: - `WindowExpression.hasWindowExpression`: `e.find(_.isInstanceOf[WindowExpression]).isDefined` -> `e.exists(...)` - `AliasHelper.getAliasMap`: `a.child.find(_.isInstanceOf[AggregateExpression]).isEmpty` -> `!a.child.exists(...)` - `Analyzer.ResolveSQLFunctions.hasSQLFunctionExpression`: `_.find(_.isInstanceOf[SQLFunctionExpression]).nonEmpty` -> `_.exists(...)` - `V2TableRefreshUtil.containsCommand`: `plan.find(_.isInstanceOf[Command]).isDefined` -> `plan.exists(...)` ### Why are the changes needed? `find(pred).isDefined` / `find(pred).nonEmpty` are equivalent to `exists(pred)`, and `find(pred).isEmpty` to `!exists(pred)` -- the same short-circuiting traversal, but `find` allocates an `Option` for the first match only for it to be discarded by the presence check. `exists` returns the `Boolean` directly and reads more clearly. Behavior is unchanged. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. This is a behavior-preserving refactor; the `catalyst` and `sql` (core) modules compile cleanly. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #58941 from uros-b/windowexpr-find-to-exists. Authored-by: Uros <221401595+uros-b@users.noreply.github.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit 5de0528) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Several places in
catalystand SQL core test for a matching node/element withfind(pred)followed by anOptionpresence check. OnTreeNode(and Scala collections)exists(pred)is the equivalent, returning theBooleandirectly. This replaces the pattern in four spots:WindowExpression.hasWindowExpression:e.find(_.isInstanceOf[WindowExpression]).isDefined->e.exists(...)AliasHelper.getAliasMap:a.child.find(_.isInstanceOf[AggregateExpression]).isEmpty->!a.child.exists(...)Analyzer.ResolveSQLFunctions.hasSQLFunctionExpression:_.find(_.isInstanceOf[SQLFunctionExpression]).nonEmpty->_.exists(...)V2TableRefreshUtil.containsCommand:plan.find(_.isInstanceOf[Command]).isDefined->plan.exists(...)Why are the changes needed?
find(pred).isDefined/find(pred).nonEmptyare equivalent toexists(pred), andfind(pred).isEmptyto!exists(pred)-- the same short-circuiting traversal, butfindallocates anOptionfor the first match only for it to be discarded by the presence check.existsreturns theBooleandirectly and reads more clearly. Behavior is unchanged.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests. This is a behavior-preserving refactor; the
catalystandsql(core) modules compile cleanly.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)