Skip to content

[SPARK-59699][CONNECT] Make DataFrameReader options case-insensitive #58951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haoyangeng-db wants to merge 2 commits into from
Closed

[SPARK-59699][CONNECT] Make DataFrameReader options case-insensitive #58951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42d0c96
[SPARK-59699][CONNECT] Make DataFrameReader options case-insensitive
haoyangeng-db Sep 21, 2026
e892e72
[SPARK-59699][CONNECT] Explain reader option deduplication
haoyangeng-db Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/pyspark/sql/connect/readwriter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ def schema(self, schema: Union[StructType, str]) -> "DataFrameReader":
schema.__doc__ = PySparkDataFrameReader.schema.__doc__

def option(self, key: str, value: "OptionalPrimitiveType") -> "DataFrameReader":
# Remove case-insensitive matches so the latest spelling and value win.
normalized_key = key.lower()
for existing_key in list(self._options):
if existing_key.lower() == normalized_key:
del self._options[existing_key]
self._options[key] = cast(str, to_str(value))
return self

Expand Down
16 changes: 16 additions & 0 deletions python/pyspark/sql/tests/connect/test_connect_plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,22 @@ def test_datasource_read(self):
self.assertEqual(len(data_source.paths), 1)
self.assertEqual(data_source.paths[0], "test_path")

def test_reader_options_case_insensitive(self):
reader = DataFrameReader(self.connect)
df = (
reader.option("versionAsOf", 0)
.option("versionasof", 1)
.option("versionAsOf", 2)
.table("myTable")
)
options = df._plan.to_proto(self.connect).root.read.named_table.options
self.assertEqual(dict(options), {"versionAsOf": "2"})

reader = DataFrameReader(self.connect)
df = reader.option("header", False).option("HEADER", True).load(format="csv")
options = df._plan.to_proto(self.connect).root.read.data_source.options
self.assertEqual(dict(options), {"HEADER": "true"})

def test_relation_changes(self):
reader = DataFrameReader(self.connect)
df = reader.option("startingVersion", "1").option("endingVersion", "5").changes("myTable")
Expand Down