Skip to content

[SPARK-59549][PYTHON][TEST][FOLLOWUP] Add ARM expected results for pandas.Series.astype tests #58952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Spenserrrr wants to merge 1 commit into from
+24 −3
Closed

[SPARK-59549][PYTHON][TEST][FOLLOWUP] Add ARM expected results for pandas.Series.astype tests #58952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions python/pyspark/tests/upstream/pandas/test_pandas_series_astype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"""

import datetime
import platform
import unittest
import warnings
from decimal import Decimal
Expand Down Expand Up @@ -361,9 +362,27 @@ def _pandas_3_overrides() -> dict[tuple[str, str], str]:
)
return overrides

def _version_overrides(self) -> dict[tuple[str, str], str]:
@staticmethod
def _arm_overrides() -> dict[tuple[str, str], str]:
"""ARM maps positive infinity to the int64 maximum in these casts; x86 yields NaT."""
return {
("float64:nonfinite", "datetime64[ns]"): (
"[NaT, Timestamp('2262-04-11 23:47:16.854775807'), NaT]@Series[datetime64[ns]]"
),
("float64:nonfinite", "datetime64[us]"): (
"[NaT, Timestamp('294247-01-10 04:00:54.775807'), NaT]@Series[datetime64[us]]"
),
("float64:nonfinite", "timedelta64[ns]"): (
"[NaT, Timedelta('106751 days 23:47:16.854775807'), NaT]@Series[timedelta64[ns]]"
),
("float64:nonfinite", "timedelta64[us]"): (
"[NaT, Timedelta('106751991 days 04:00:54.775807'), NaT]@Series[timedelta64[us]]"
),
}

def _overrides(self) -> dict[tuple[str, str], str]:
"""
Return expected cells that differ from the pandas 2.3.3 / NumPy 2 baseline.
Return expected cells that differ from the pandas 2.3.3 / NumPy 2 x86 baseline.

Conditions are independent because one dependency profile can require several
groups at once. No PyArrow-specific overrides were needed across versions 18-25.
Expand All @@ -376,6 +395,8 @@ def _version_overrides(self) -> dict[tuple[str, str], str]:
overrides.update(self._pandas_before_2_3_0_overrides())
if pandas_version >= "3.0.0":
overrides.update(self._pandas_3_overrides())
if platform.machine() in ("aarch64", "arm64"):
overrides.update(self._arm_overrides())
return overrides

def _test_astype(self, golden_file_prefix, **kwargs):
Expand All @@ -396,7 +417,7 @@ def compute_cell(row_name, col_name):
col_names=[COL_INPUT, *targets],
compute_cell=compute_cell,
golden_file_prefix=golden_file_prefix,
overrides=self._version_overrides(),
overrides=self._overrides(),
)

def test_astype_default(self):
Expand Down