[SPARK-59702][K8S][4.X] Use KeyToPathBuilder instead of KeyToPath constructor - #58954
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
HyukjinKwon
approved these changes
Sep 21, 2026
Member
Author
|
Thank you, @HyukjinKwon . 😄 |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 22, 2026
… constructor ### What changes were proposed in this pull request? This PR aims to use the fluent `KeyToPathBuilder` instead of the positional `KeyToPath` constructor in `KubernetesClientUtils` and `ClientSuite`. ### Why are the changes needed? `KeyToPath` gains new fields as new Kubernetes versions are supported, and each addition changes the canonical constructor signature and breaks compilation. The builder names every field it sets and is already the prevailing style in this module (e.g. `HadoopConfDriverFeatureStep`, `KerberosConfDriverFeatureStep`). ### Does this PR introduce _any_ user-facing change? No. The builder produces the same `KeyToPath` objects as before. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5 Closes #58954 from dongjoon-hyun/SPARK-59702. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Merge Summary:
Posted by |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 22, 2026
… constructor This PR aims to use the fluent `KeyToPathBuilder` instead of the positional `KeyToPath` constructor in `KubernetesClientUtils` and `ClientSuite`. `KeyToPath` gains new fields as new Kubernetes versions are supported, and each addition changes the canonical constructor signature and breaks compilation. The builder names every field it sets and is already the prevailing style in this module (e.g. `HadoopConfDriverFeatureStep`, `KerberosConfDriverFeatureStep`). No. The builder produces the same `KeyToPath` objects as before. Pass the CIs. Generated-by: Claude Opus 5 Closes #58954 from dongjoon-hyun/SPARK-59702. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit d9c20f6) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
I backported this to branch-4.3 too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use the fluent
KeyToPathBuilderinstead of the positionalKeyToPathconstructor inKubernetesClientUtilsandClientSuite.Why are the changes needed?
KeyToPathgains new fields as new Kubernetes versions are supported, and each addition changes the canonical constructor signature and breaks compilation. The builder names every field it sets and is already the prevailing style in this module (e.g.HadoopConfDriverFeatureStep,KerberosConfDriverFeatureStep).Does this PR introduce any user-facing change?
No. The builder produces the same
KeyToPathobjects as before.How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5