[SYSTEMDS-3955] Add signed SSL certificates support - #2569
Open
gaturchenko wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading in a signed certificate and makes the coordinator verify it in place of the existing self-signed certificate generation. To that end, the XML config is extended with the following:
trueby defaultBoth certificate and key are read by each worker from its own config, so they are local per worker. The coordinator has a single trust file, where one CA certificate covers any number of workers, and multiple CAs can be concatenated into one PEM. With hostname verification on, a worker's certificate must be issued for the address the script connects to (
san=dns:..., orsan=ip:...for IP literals), so a certificate valid for one worker cannot be replayed for another.NB: private keys and certificates are added as a part of this PR for SSL-enabled tests to work. They are generated with a dedicated shell script and are irrelevant for anything except the tests.