Repository navigation
Conversation
vdusek
added
adhoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The camoufox templates broke on master on Oct 5 and Oct 6 with
UnknownProperty: Unknown property navigator.product in config. camoufox-js validates the fingerprint against theproperties.jsonthat ships inside the downloaded Camoufox browser. Browser releasesv156.0.1-beta.32throughbeta.35droppednavigator.product, but the fingerprint mapping still emits it.camoufox-js 0.12.0 accepts any browser release, so
camoufox-js fetchgrabbed those builds. 0.12.1 limits the browser to<beta.32. Raising the floor to^0.12.1keeps the templates on that range.beta.36puts the property back, which is why master is green again, but this stops the next browser release from breaking the templates the same way.✍️ Drafted by Claude Code