K2GO-377 chore(rootfs): rebrand the rootfs artifacts - #528
Merged
Merged
Conversation
… old ones once The rootfs images carried the iiab-oa_ prefix from the upstream project. They are the product's own artifacts, so they take its name; the stable pointers keep theirs, since latest_<tier>_<arch>.meta4/.installed never carried a product prefix. The app is unaffected: it asks for the pointer and takes the file name and URL from inside the metalink, so it never builds the artifact name itself. The publish loop and the retention prune move to k2go_ together — a prune left filtering the old prefix would let the new artifacts pile up at ~1.7 GB each while still eating the old ones. A transitional sweep clears the pre-rename artifacts in full instead of ageing them out seven deep, and is marked for removal before merge: run the workflow from this branch to migrate the bucket, confirm no iiab-oa_ keys remain, then delete the block so it does not outlive its purpose. ROOTFS_PUBLIC_BASE comes along from K2GO-90: on main it still defaults to a path-based route that was never created, so a migration build run without it would republish metalinks pointing at 404.
… too The suggested filename kept the iiab-oa_ prefix the built artifacts just left behind, so the app would have written backups under one name while the bucket held another. It is only ever a suggestion for the SAF picker: nothing reads it back, and a restore identifies an archive by the manifest inside it, so backups already written under the old name keep restoring unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rootfs images in the Cloudflare bucket carried the upstream project's
iiab-oa_prefix. Theyare this product's artifacts, so they take its name.
k2go_<date>_<tier>_<sha>_<arch>.tar.gz.latest_<tier>_<arch>.meta4/.installedare unchanged — they never carried a product prefix.the new artifacts pile up at ~1.7 GB each while still eating the old ones.
iiab-oa_*into ak2go_*world.No app changes needed. It asks for the pointer and takes the file name and URL from inside the
metalink; it never builds an artifact name. Restores identify an archive by the manifest inside it,
so backups written under the old name keep working.
One line from K2GO-90 comes along:
ROOTFS_PUBLIC_BASEstill defaults on main to a path-basedroute that was never created, so metalinks published with it 404 on the tarball with no mirror to
fall back on. Without it the migration build would republish the same broken pointers.
The sweep block is transitional — remove it before merging:
iiab-oa_keys remain (the command is in the block's comment). This gates step 3 —not the run having finished. Leftovers would outlive the only code that clears them.
Out of scope: the app-side origins and the builder's
BASE_HOSTstill name switnet. That isK2GO-90's change, on its own branch.