K2GO-439 fix(ui): handle edge-to-edge insets on targetSdk 35 - #613
Merged
Merged
Conversation
Android 15+ forces edge-to-edge, so app content and WebViews drew under the status and navigation bars. Add an EdgeToEdge helper and an app-wide ActivityLifecycleCallbacks owner that pads each activity's content by the system-bar insets; LibraryActivity pads its content and bottom nav directly and SplashActivity stays fullscreen, both opting out via EdgeToEdge.SelfManaged.
Opt HelpViewerActivity out of the global handler (its fitsSystemWindows layout already insets) and document the SelfManaged rule; pad the LibraryActivity content container so the rail and both orientations are covered; clear the IME in the global handler so fields are not hidden; extract a unit-tested resolvePadding; fix the stale PortalActivity comments.
…erlay Final-review fixes: remove windowSoftInputMode=adjustResize from TerminalActivity so the global padAllAndIme is the single IME handler, and pad the install_progress overlay (a sibling of the content container) so its controls clear the navigation bar.
The Material BottomNavigationView and NavigationRailView inset themselves for the navigation bar, so padding the content container's bottom too left a large empty gap under the nav (seen on Settings). Pad only the top of the content for the status bar and let the Material nav components handle the bottom; drop the now-unused content container id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At targetSdk 35 Android 15+ forces edge-to-edge, so app content and WebViews drew under the
status and navigation bars.
Changes:
app-wide ActivityLifecycleCallbacks owner that insets each activity's content, with a
SelfManaged opt-out.
inset themselves for the navigation bar; the install overlay is inset too.
(WebView) stays in so the global handler insets it, including when its immersive mode hides
the bars.
Verified on-device (OnePlus 7T / Android 15, Samsung A16 / Android 16): native screens and the
content WebView keep clear of both system bars.