Skip to content

K2GO-439 fix(theme): dark status bar icons in light theme #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luisguzman-adfa merged 2 commits into from
Oct 3, 2026
Merged

K2GO-439 fix(theme): dark status bar icons in light theme #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3138c5c
K2GO-439 fix(theme): dark status bar icons in light theme
luisguzman-adfa Oct 3, 2026
510667d
K2GO-439 fix(theme): drop windowLightNavigationBar (NewApi vs minSdk 24)
luisguzman-adfa Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions controller/app/src/main/res/values-night/bools.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<!-- K2GO-439 follow-up: dark theme. false = dark bars, so the OS draws light (white) icons. -->
<bool name="k2go_light_system_bars">false</bool>
</resources>
6 changes: 6 additions & 0 deletions controller/app/src/main/res/values/bools.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<!-- K2GO-439 follow-up: light theme. true = the system bars are light, so the OS draws dark
icons, readable on the light background. Dark twin in values-night/bools.xml. -->
<bool name="k2go_light_system_bars">true</bool>
</resources>
6 changes: 6 additions & 0 deletions controller/app/src/main/res/values/themes_k2go.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@
variants. All share ShapeAppearance.K2Go.Button (official M3 full/pill), so the corner lives in
one place and primary/secondary never disagree. -->
<item name="materialButtonStyle">@style/Widget.K2Go.Button</item>
<!-- K2GO-439 follow-up: targetSdk 35 forces edge-to-edge and drops the auto status-bar scrim,
so the app must set the status-bar icon contrast itself (Material3 does not default it).
true means a light bar with dark icons. Day/night qualified in values[-night]/bools.xml,
the same pattern as the color tokens. windowLightNavigationBar is not set: the nav bar
renders correctly already, and that attr is API 27 (above the minSdk 24). -->
<item name="android:windowLightStatusBar">@bool/k2go_light_system_bars</item>
</style>

<!-- ADFA-5346: shared button shape — official Material 3 fully-rounded (stadium/pill). Change here to
Expand Down