K2GO-443 feat(code-addons): add-ons gallery updater on the durable job engine - #627
Merged
Merged
Conversation
… engine (dash-node 1.3.12) The gallery updater moves from the fire-and-forget wrapper to the durable job engine. Only the heavy add-on binaries (.cgp + source tarballs) go through aria2 (resume / pause / retry, survives a network change); the mirror stages the small files (shell, catalog, icons, pages) with its Cloudflare clean and catalog base rewrite. mirror_addons.py splits into --print-aria2-input (stage + emit the heavy input, with a #status marker so a small-file-only change still swaps) and --finalize-only (verify presence); one shared _stage core keeps the bake / legacy-wrapper path unchanged.
…sh-wrapper client AddonsDownloadService extends ContentDownloadServiceBase (K2GO-449 shared base), and AddonsRefresh now drives it: a determinate bar with speed, pause/resume, cancel, injected after the trigger, re-attaching when the sheet reopens. Removes AddonsRefreshClient (the POST-then-poll wrapper client). ModuleActions already routes code_addons to AddonsRefresh.start.
Notification id 8 is also ForgejoSeedService and CloneShareService; an add-ons download and a forgejo seed can be foreground at once, so give the add-ons service a free id (11).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add-ons gallery content updater moves from the fire-and-forget refresh wrapper to the durable job
engine: live progress (percent/speed), pause/resume/retry, and resilience to a network change or drop.
Only the heavy add-on binaries (.cgp + source tarballs) go through aria2 (verified by sha-256); the
mirror stages the small files (shell, catalog, icons, pages) with its Cloudflare clean and catalog base
rewrite. Incremental: unchanged files reuse by the catalog sha; a same-build catalog short-circuits as
up to date.
dash-node 1.3.12: code-addons is a job type (POST /code-addons/download, GET /code-addons/jobs/:id,
pause/resume/retry/cancel over the generic /:type/* surface, like build-assets). Runner
sockets/code_addons.exec.ts + the shared sockets/aria2-download.ts; mirror_addons.py keeps the content
work (--print-aria2-input stages the small files and emits the heavy aria2 input, with a #status marker
so a small-file-only change still swaps; --finalize-only verifies). One shared _stage core keeps the
bake and legacy-wrapper path unchanged.
App: AddonsDownloadService (foreground, extends the shared ContentDownloadServiceBase) + reworked
AddonsRefresh (determinate bar, speed, pause/resume, cancel); removes AddonsRefreshClient. ModuleActions
already routes code_addons to AddonsRefresh.start.
The older POST /addons/refresh (wrapper) stays for now.
Verified: dash-node typecheck, app compile, l10n, mirror self-test, double-pass review (fix: unique
notification id).