K2GO-443 fix(app): module icons from one source (Module management + members sheet) - #629
Merged
Merged
Conversation
The add-ons work gave the Home members sheet distinct glyphs (add-ons = extension, build assets = box), but ModuleCards: the canonical source used by Settings > Module management and the action-sheet header: still mapped both to the code glyph. Point code_addons -> ic_card_addons and code_assets -> ic_card_assets so both surfaces match.
…s (one icon source) The member rows hardcoded their glyphs, a second place to update (the drift that left Module management on the old icon). They now read ModuleCards.byEndpoint(endpoint).imageRes, so a module's icon is set once in ModuleCards and shows the same in Module management, the module detail, the action-sheet header and the Home members row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The add-ons work gave the Home "Code on the Go Dev" members sheet distinct glyphs (Add-ons = extension,
Build assets = box), but ModuleCards: the canonical source used by Settings > Module management, the
module detail and the action-sheet header: still mapped both to the code glyph, so those surfaces kept
showing the code icon. Two changes:
from the add-ons PR).
it, so a module's icon lives in ONE place and shows the same in Module management, the module detail,
the action-sheet header and the Home members row (no more drift).
Verified on device: the Module management detail for Add-ons shows the extension glyph.