Repository navigation
chore: ビルド・テスト・リリース環境の最新化と生成物の Git 管理除外 - #41
Merged
Merged
Conversation
lib/ と js/ はソースから再生成できる成果物で、コミットされていると ソース変更のたびに差分が混ざり、古い成果物がそのまま残る事故が起きる (実際に js/ だけ src より古い状態だった)。SmartPhoto / a-table.js と 同じ構成に揃え、成果物は prepack 時にのみ生成する。 - browserify/babel/uglify/np を tsup に置き換え (CJS/ESM/IIFE を出力) - ESLint 10 flat config + @Stylistic に移行 - vitest + jsdom のテストを追加し、カバレッジ 90% 未満で失敗させる - Dependabot と minor/patch の自動マージ、Node CI を追加 - タグ push で npm Trusted Publishing (OIDC) により公開 - checkScrollableDir が先頭の子要素ではなく scrollWidth を見るよう修正 (テキストのみのコンテナで方向クラスが付かない問題) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
SmartPhoto / a-table.js と表記を揃えるため。 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
SmartPhoto / a-table.js と同じ構成に揃えました。
lib/js/を Git 管理から外し、prepack時のみ生成@stylisticに移行v*.*.*タグ push で npm Trusted Publishing (OIDC) により公開checkScrollableDirがelement.scrollWidthを見るよう修正 (Fix suggestive shadows for text-only scroll containers #40 と同じ修正。テキストのみのコンテナで方向クラスが付かない問題)array.prototype.finddelegateを削除注意
lib/util.jsはlib/index.jsに統合されますappleple/scroll-hintのpublish.yml) の登録が必要です検証
npm run prepack(lint / テスト / ビルド) がローカルで通ることを確認済み。🤖 Generated with Claude Code