Add relay-enabled VaultServer to service-vault chart - #1327
Open
ArnobKumarSaha wants to merge 3 commits into
Open
Add relay-enabled VaultServer to service-vault chart#1327ArnobKumarSaha wants to merge 3 commits into
ArnobKumarSaha wants to merge 3 commits into
Conversation
ProductLine: ACE Release: v2026.9.11 Release-tracker: appscode-cloud/CHANGELOG#78 Signed-off-by: 1gtm <1gtm@appscode.com>
Expand vaultServer values into a full spec (version, replicas, isolateTenants, serviceType, persistence, unsealer, tls, relay, terminationPolicy) and rewrite the VaultServer template around it. Add a namespaced cert-manager CA Issuer for the VaultServer's serving TLS, plus the OCM ManagedClusterSetBinding and Placement that relayPlacementRef targets. Vendor the two OCM CRDs via import-crds.sh. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
v0.23.0 lacked isolateTenants, relayPlacementRef, and relayTemplate on VaultServer v1alpha2, so the API server pruned them. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
force-pushed
the
master
branch
2 times, most recently
from
September 3, 2026 04:20
cc445c3 to
b38cc0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
charts/service-vaultin line with the target manifest: a relay-enabledVaultServerplus the cert-managerIssuerand OCMPlacement/ManagedClusterSetBindingit depends on.Changes
values.yaml—vaultServergrows from{name}into a full spec:version,replicas,isolateTenants,serviceType,terminationPolicy,persistence,unsealer,tls.caSecretName,relay.{clusterSet,namespace,bootstrapTokenTTL}.apis/installer/v1alpha1/service_vault_types.go—ServiceVaultSpec.VaultServerchanges fromLocalObjectReferenceto a newVaultServerSpec.templates/vault/ca-issuer.yaml(new) — namespaced cert-managerIssuer{{ service-vault.fullname }}-ca-issuerfor the VaultServer's serving TLS. Usesca.secretNamewhenvaultServer.tls.caSecretNameis set, otherwiseselfSigned: {}. Named distinctly from the existingvault-issuerClusterIssuer, which serves the opposite flow (cert-manager issuing certs from Vault's PKI).templates/vault/placement.yaml(new) —ManagedClusterSetBinding+Placement(numberOfClusters: 1,cluster.appscode.com/profilepredicate) thatrelayPlacementReftargets.templates/vault/vault-server.yaml— rewritten around the new values.serviceTemplatesis emitted only whenserviceTypeis notClusterIP, so the existing Gateway/HTTPRoute exposure ingw.yamlstays the default. Themonitorblock is preserved.hack/scripts/import-crds.sh— bumpsKUBEVAULT_APIMACHINERY_TAGfromv0.23.0tov0.25.0and vendors the two OCM CRDs intocharts/service-vault/crds(same upstream inputs already used by the license-proxyserver-manager block).The tag bump is required:
v0.23.0had noisolateTenants,relayPlacementRef, orrelayTemplateonVaultServer, so structural-schema pruning would have dropped all three at the API server. All four fields the templates emit are confirmed present underv1alpha2in the re-imported CRD.Verification
go build ./...cleanmake genrun; generatedREADME.md,values.openapiv3_schema.yaml, and deepcopy are currenthelm lint charts/service-vaultpasseshelm templatechecked for both the default (ClusterIP +ca.secretName) and theLoadBalancer+ empty-caSecretName(selfSigned) variants