Skip to content

Fix Milvus object storage secret filter and label - #1167

Merged
ArnobKumarSaha merged 1 commit into
masterfrom
arnob-milvus-sec
Sep 5, 2026
Merged

Fix Milvus object storage secret filter and label#1167
ArnobKumarSaha merged 1 commit into
masterfrom
arnob-milvus-sec

Conversation

@ArnobKumarSaha

Copy link
Copy Markdown
Member

The Object Storage Config Secret dropdown in kubedbcom-milvus-editor-options was always empty: getSecrets filtered for a config.env data key, which the Milvus object storage secret never contains.

  • ui/functions.js — filter on the actual MinIO/S3 config keys (address, port, accessKeyID, secretAccessKey, bucketName). rootPath is left out of the required set since it is an optional path prefix.
  • ui/create-ui.yaml — rename the field label Config Secret -> Object Storage Secret.

Matching secret shape:

apiVersion: v1
kind: Secret
metadata:
  name: milvus-storage-config
  namespace: demo
stringData:
  address: "minio.minio.svc.cluster.local"
  port: "9000"
  accessKeyID: "rootuser"
  secretAccessKey: "rootpass123"
  bucketName: "milvus"
  rootPath: "files"

Not addressed here: kubedbcom-milvus-editor never surfaces spec.objectStorage.configSecret.name even though objectStorage is required by the Milvus CRD.

The Config Secret dropdown filtered on a 'config.env' data key, which the
object storage secret never contains, so the list was always empty. Filter
on the MinIO/S3 config keys instead and rename the field to Object Storage
Secret.

Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
@ArnobKumarSaha
ArnobKumarSaha merged commit 6112f56 into master Sep 5, 2026
4 checks passed
@ArnobKumarSaha
ArnobKumarSaha deleted the arnob-milvus-sec branch September 5, 2026 19:32
ArnobKumarSaha added a commit that referenced this pull request Sep 6, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha added a commit that referenced this pull request Sep 7, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha added a commit that referenced this pull request Sep 7, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Shofiqur-052 pushed a commit that referenced this pull request Sep 7, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Signed-off-by: shofiq <shofiq@appscode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant