Fix Milvus object storage secret filter and label - #1167
Merged
Conversation
The Config Secret dropdown filtered on a 'config.env' data key, which the object storage secret never contains, so the list was always empty. Filter on the MinIO/S3 config keys instead and rename the field to Object Storage Secret. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha
added a commit
that referenced
this pull request
Sep 6, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha
added a commit
that referenced
this pull request
Sep 7, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha
added a commit
that referenced
this pull request
Sep 7, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Shofiqur-052
pushed a commit
that referenced
this pull request
Sep 7, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com> Signed-off-by: shofiq <shofiq@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Object Storage
Config Secretdropdown inkubedbcom-milvus-editor-optionswas always empty:getSecretsfiltered for aconfig.envdata key, which the Milvus object storage secret never contains.ui/functions.js— filter on the actual MinIO/S3 config keys (address,port,accessKeyID,secretAccessKey,bucketName).rootPathis left out of the required set since it is an optional path prefix.ui/create-ui.yaml— rename the field labelConfig Secret->Object Storage Secret.Matching secret shape:
Not addressed here:
kubedbcom-milvus-editornever surfacesspec.objectStorage.configSecret.nameeven thoughobjectStorageis required by the Milvus CRD.