Repository navigation
Wait for async-enabled controls in tapAsync, add expectEnabledAsync - #2
Merged
Merged
Conversation
Since iOS 27 SwiftUI refreshes toolbar items as async main-actor work, which the synchronous pump never drains. After an edit, a bar button stays disabled until the test suspends. - tapAsync retries a control it cannot activate yet until its timeout, settling in between. - expectEnabledAsync waits for an enabled element. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since iOS 27, SwiftUI refreshes toolbar items as async main-actor work. The synchronous API (
tap,pump,expect) spins a nested run loop that does not drain this work. After an edit, a bar button stays disabled, and keeps its old action closure, until the test suspends. Tests that tap "Done" or checkisEnabledright after an edit fail. The failures depend on test order.Change
tapAsyncretries a control it cannot activate yet (for example a disabled one) until its timeout, and settles in between. A control that stays disabled still throws, now after the timeout.expectEnabledAsync(_:timeout:): waits until an element with the label is enabled.Tests
tapAsyncwaits for a control that async work enables,expectEnabledAsyncwaits for it, andtapAsyncstill refuses a control that stays disabled.🤖 Generated with Claude Code