Repository navigation
fix(patch): send JSON patches with slashes and unicode unescaped - #44
Merged
Merged
Conversation
The API server compares a JSON patch test operation's strings by their encoded bytes, so PHP's default \/ never matched a stored / and any test on a value containing a path (an init container's command, a mount path) was refused with 422 Invalid. toJsonPayload already used JSON_UNESCAPED_SLASHES; the patch encoders now match it, and keep unicode verbatim for the same reason.
🟢 Tier S · Ready to mergeThis changes JSON Patch and JSON Merge Patch payload serialization to emit slashes and Unicode characters without JSON escapes. The payload tests now check literal paths, script strings, non-ASCII values, and merge-patch annotations.
📂 Walkthrough · 2
🔇 Filtered out · 1Findings Hansi considered but did not post.
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API server compares a JSON patch
testop's strings by their encoded bytes. PHP's defaultjson_encodewrites\/, so anyteston a value containing a path never matched and the patch was refused with422 Invalid.Same for
toJsonMergePatchPayload.Found live: edge's sweep tests a StatefulSet's
initContainers(whose command contains/var/run/mysqld) before replacing them; every tick got 422. The identical payload with slashes unescaped passes a server dry-run.Tests in
PatchPayloadTest: atestop with paths and non-ASCII stays verbatim; a merge patch keepsa/b; the pinned scalar case now expects unescaped paths. All three fail without the fix.