Skip to content

test: stabilize stale cluster snapshot clock #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammarheidari merged 2 commits into from
Sep 24, 2026
Merged

test: stabilize stale cluster snapshot clock #149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
562173e
test: stabilize stale cluster snapshot clock
ammarheidari Sep 23, 2026
fcb63c5
chore(ci): reconcile test stabilization with protected main
ammarheidari Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions tests/Kafdeck.Architecture.Tests/ClusterExplorerServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public async Task Capability_denial_is_a_limitation_without_changing_healthy_met
[Fact]
public async Task Retryable_refresh_failure_serves_stale_metadata_as_degraded()
{
var clock = new MutableTestTimeProvider(DateTimeOffset.UtcNow);
var calls = 0;
var port = new FakeKafkaAdministrationPort
{
Expand All @@ -72,20 +73,20 @@ public async Task Retryable_refresh_failure_serves_stale_metadata_as_degraded()
var call = Interlocked.Increment(ref calls);
if (call == 1)
{
var oldObservation = Observation(DateTimeOffset.UtcNow - TimeSpan.FromMilliseconds(1500));
var oldObservation = Observation(clock.GetUtcNow() - TimeSpan.FromMilliseconds(1500));
return Task.FromResult(KafkaResult<ClusterMetadata>.Success(Metadata("cluster-a"), oldObservation));
}

return Task.FromResult(KafkaResult<ClusterMetadata>.Failed(
Failure(KafkaFailureCategory.Unavailable, "temporarily_unavailable", true),
Observation()));
Observation(clock.GetUtcNow())));
},
Capabilities = (_, _, _) => Task.FromResult(KafkaResult<KafkaCapabilities>.Success(
new KafkaCapabilities(Array.Empty<KafkaCapabilityStatus>()),
Observation())),
Observation(clock.GetUtcNow()))),
};
var policy = Policy(clusterMetadataTtl: TimeSpan.FromSeconds(1));
var service = new ClusterExplorerService(port, new KafkaSnapshotCoordinator(policy), policy);
var service = new ClusterExplorerService(port, new KafkaSnapshotCoordinator(policy, clock), policy);

var initial = await service.GetClusterAsync("cluster-a");
var stale = await service.GetClusterAsync("cluster-a");
Expand Down Expand Up @@ -149,6 +150,18 @@ private static KafkaFailure Failure(
bool retryable) =>
new(category, code, "Safe failure.", retryable);

private sealed class MutableTestTimeProvider : TimeProvider
{
private readonly DateTimeOffset _utcNow;

public MutableTestTimeProvider(DateTimeOffset utcNow)
{
_utcNow = utcNow;
}

public override DateTimeOffset GetUtcNow() => _utcNow;
}

private sealed class FakeKafkaAdministrationPort : IKafkaAdministrationPort
{
public Func<string, KafkaOperationContext, CancellationToken, Task<KafkaResult<ClusterMetadata>>>? ClusterMetadata { get; init; }
Expand Down Expand Up @@ -196,4 +209,4 @@ public Task<KafkaResult<KafkaCapabilities>> GetCapabilitiesAsync(
new KafkaCapabilities(Array.Empty<KafkaCapabilityStatus>()),
Observation()));
}
}
}
Loading