Skip to content

feat(analytics): add bounded consumer analytics UI parity - #246

Closed
ammarheidari wants to merge 1 commit into
mainfrom
w64-analytics-ui-parity
Closed

ammarheidari wants to merge 1 commit into
mainfrom
w64-analytics-ui-parity

Conversation

@ammarheidari

Copy link
Copy Markdown
Contributor

Authority

W64 #213 is ACTIVE. PR #245 backend live/history/SLO runtime is protected-main verified at 03092cea799bc6f1afb1f8671d8b1b4c527de257.

UI parity slice

  • typed frontend contracts for live operational evidence, bounded lag trends and SLO results;
  • consumer detail loads existing live/trend analytics independently from core read-view detail;
  • explicit Available/Partial/Stale/Unavailable/Unknown status presentation;
  • provider/truncation/limit truth is operator-visible;
  • trend table renders only the most recent 50 bounded points;
  • SLO evaluation is explicit operator action with bounded server evidence;
  • incomplete/mixed evidence remains partial/unavailable rather than being presented as healthy;
  • no new metrics provider and no fabricated broker/topic/consumer rates.

Safety

  • no direct Kafka/provider/database access;
  • no mutation/API bypass;
  • analytics failure does not suppress the existing consumer read view;
  • no unbounded history rendering;
  • no new chart/runtime dependency;
  • no raw payload exposure.

Exact head: a2ab780a0eac0026e56c02e9377e13c30a080330.

Refs #213.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T12:35:36.282202Z 08fedc0 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head a2ab780a0eac0026e56c02e9377e13c30a080330 only. Focus on typed API parity, evidence-state truth, bounded trend rendering, analytics/read-view isolation, SLO validation and any frontend security/regression concerns.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2ab780a0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx Outdated
Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx Outdated
Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx Outdated
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
@ammarheidari
ammarheidari force-pushed the w64-analytics-ui-parity branch from 68197be to 08fedc0 Compare October 4, 2026 12:31

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head 08fedc0407909e1ee358ac1c74f87d8de3046e43 only. The prior P1/P2 findings are addressed with consumer-generation fencing, independent live/trend settlement, SLO request/input invalidation, and explicit evaluated-definition rendering. Focus on stale-response safety, partial-provider behavior, and frontend regressions.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08fedc0407

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx
Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx
Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx
@akhiabanchian
akhiabanchian self-requested a review October 4, 2026 13:04

Copy link
Copy Markdown
Contributor Author

Closing as superseded rather than rebasing conflict resolution. PR #246 is the earlier W64 consumer-analytics UI parity implementation and is now 4 commits behind main, conflicts on the same frontend files, and still carries three unresolved P2 review findings. Its intended scope has been replaced by the hardened, exact-head reviewed implementation merged through PR #247, followed by provider-truth closeout PR #248. Rebasing #246 would reintroduce older UI/API/race/error-state behavior already corrected in #247. No unique W64 capability remains only in #246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants