feat(data-quality): add bounded batch evaluator runtime - #249
ammarheidari wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Please review exact head |
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
9fdca6e to
d22fece
Compare
|
@codex review Please review exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d22fecef89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var decoded = | ||
| await _decoder.DecodeAsync( | ||
| new RecordDecodeRequest( | ||
| input.ClusterId, | ||
| input.TopicName, | ||
| input.Partition, | ||
| record.Offset, | ||
| isKey: false, | ||
| record.Value.Value), | ||
| new KafkaOperationContext( | ||
| deadline), | ||
| cancellationToken) | ||
| .ConfigureAwait(false); |
There was a problem hiding this comment.
Recheck the deadline after decoding each record
If the final record starts decoding before the deadline but the schema lookup or synchronous deserialization finishes after it, this method immediately evaluates the rules and returns Complete because there is no subsequent loop iteration to perform another deadline check. The concrete ConfluentRecordDecoder checks expiry before its potentially expensive lookup/decode work, so passing the deadline downstream does not prevent this case; recheck the effective deadline after the await and report DurationLimit without counting the unfinished record.
Useful? React with 👍 / 👎.
Authority
W65 / #214 is ACTIVE. Slice 1 bounded policy/evidence contracts and Slice 2 evaluator/progress contracts are protected-main verified.
Slice 3 scope
IDataQualityBatchEvaluatorover an already-authorized, finiteDataQualityEvaluationInput;IRecordDecodePortfor structured value decoding;Safety
Exact head:
d22fecef89a86440a529ebb589d5d39ee04903c8.Refs #214 #209.
Corrective exact-head
ReadOnlyMemory<byte>;