Skip to content

feat(data-quality): add W65 lifecycle persistence contracts - #252

Merged
ammarheidari merged 1 commit into
mainfrom
w65-data-quality-lifecycle-foundation
Oct 4, 2026
Merged

ammarheidari merged 1 commit into
mainfrom
w65-data-quality-lifecycle-foundation

Conversation

@ammarheidari

@ammarheidari ammarheidari commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Authority

W65 / #214 is ACTIVE. Slice 3 runtime evaluator plus corrective #251 are protected-main admitted on parent 28df067746159c8a35da300cf0e0376fef0a4c3f.

Slice 4A scope

  • bounded lifecycle states for data-quality policies;
  • optimistic revision contract for durable lifecycle writes;
  • bounded policy listing by cluster/state;
  • bounded aggregate evidence/progress history query;
  • lifecycle store contract for later SQLite/PostgreSQL implementation;
  • explicit no-raw-payload durability surface.

Safety

  • no Kafka reads or consumer-group membership in this slice;
  • no offset commits;
  • no raw key/value/header/payload persistence;
  • evidence range capped at 31 days and 2,000 points;
  • policy listing capped at 500 entries;
  • lifecycle mutations require revision semantics;
  • no worker/API/UI activation yet.

Final corrective exact head: ce6e7060f44d82e9523c1193b2aaf8fb5ca44312.

Corrections included:

  • evidence/progress persistence now accepts only a validated DataQualityEvaluationResult pair;
  • durable evidence accepts only the closed server-derived bounded evaluator source;
  • create and revision-guarded replace semantics are split explicitly;
  • policy listing has bounded cursor/truncation semantics.

Refs #214 #209.

  • continuation cursors now use the same exact-ID validation as request cursors.

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head 4123eb3a495529cb4e5f251f3ed83268af16623a only. Focus on bounded lifecycle/query semantics, optimistic revision authority, evidence/progress consistency, and proving the persistence contract cannot durably carry raw Kafka key/value/header/payload material.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T18:48:40.867307Z ce6e706 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4123eb3a49

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/backend/Kafdeck.Core/Records/DataQualityLifecycleContracts.cs Outdated
Comment thread src/backend/Kafdeck.Core/Records/DataQualityLifecycleContracts.cs Outdated
Comment thread src/backend/Kafdeck.Core/Records/DataQualityLifecycleContracts.cs
Comment thread src/backend/Kafdeck.Core/Records/DataQualityLifecycleContracts.cs Outdated
akhiabanchian
akhiabanchian previously approved these changes Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review corrective exact head b8ce3936cf8b0c17c51ae91279bd742c74e7fb2a only. Verify all four prior findings are fully closed: validated evidence/progress binding, explicit create vs revision-guarded replace, closed server-derived durable evidence source, and bounded policy-list pagination/truncation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8ce3936cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/backend/Kafdeck.Core/Records/DataQualityLifecycleContracts.cs
@akhiabanchian
akhiabanchian self-requested a review October 4, 2026 18:44
akhiabanchian
akhiabanchian previously approved these changes Oct 4, 2026
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
@ammarheidari
ammarheidari force-pushed the w65-data-quality-lifecycle-foundation branch from 954c917 to ce6e706 Compare October 4, 2026 18:46

Copy link
Copy Markdown
Contributor Author

@codex review

Please review final corrective exact head ce6e7060f44d82e9523c1193b2aaf8fb5ca44312 only. Prior four findings remain addressed; additionally verify truncated policy pages only expose continuation IDs that satisfy the same exact bounded policy-ID grammar as afterPolicyId.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: ce6e7060f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammarheidari
ammarheidari merged commit 9572726 into main Oct 4, 2026
8 checks passed
@ammarheidari
ammarheidari deleted the w65-data-quality-lifecycle-foundation branch October 4, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants