Repository navigation
feat(data-quality): add W65 bounded monitoring worker - #254
Conversation
|
@codex review Please review exact head |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0583a4af8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a999a63 to
6c2546e
Compare
|
@codex review Please review corrective exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c2546e9fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
67a0211 to
67d4803
Compare
|
@codex review Please review final corrective exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67d4803cff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f985d49 to
92a6062
Compare
|
@codex review Please review final exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92a6062fc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2606dea to
4ef1c70
Compare
|
@codex review Please review final exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ef1c7061c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
91bc429 to
7dfbd6f
Compare
|
@codex review Please review final exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7dfbd6f9ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ae5dd93 to
6c69363
Compare
|
@codex review Please review final exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c693636be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a87ca44 to
36838c0
Compare
|
@codex review Please review rebased final exact head |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Retry review for exact head |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
36838c0 to
c205bbc
Compare
|
@codex review Please review latest exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c205bbc1c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b82fcd6 to
11da7ac
Compare
|
@codex review Please review final exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11da7ac360
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
df44060 to
d9a60d4
Compare
|
@codex review Please review final exact head |
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
5e4e3de to
40e447c
Compare
|
@codex review Please review final exact head |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Authority
W65 / #214 Slice 4B durable lifecycle/evidence persistence is protected-main admitted via PR #253 at baseline
8d066a2dacdbf0c647d5be81dc61eea8c8680e34.Slice 4C scope
IKafkaRecordReadPortreuse with no consumer-group membership or offset commits;IDataQualityLifecycleStore;Safety
Final corrective exact head:
40e447c4a503bacde36d1167f14271f5c33ac9f9.Refs #214 #209.
Corrective closure
source read budget outcomes now propagate into durable evaluation state/outcome instead of fabricating complete evidence;
policy throughput allowance is shared across all targeted partitions in a cycle;
records outside the captured time window are excluded conservatively and missing timestamps produce partial uncertainty rather than false completeness;
cancelled Kafka read results propagate as cancellation rather than normal source failures.
empty truncated reads now preserve a conservative lower/continuation-bound range instead of collapsing to [high, high);
future/out-of-window timestamps are treated as uncertainty across the full returned batch rather than a monotonic end boundary.
active-policy pagination now rotates from the last processed policy instead of permanently restarting from the first page;
shared policy allowance is fairly divided and partition processing resumes round-robin across cycles;
returned offsets beyond a stale captured high watermark are included in the admitted range;
complete empty reads preserve the resolved forward anchor from the source batch.
policy cursor no longer advances past a policy that performed no partition consideration because the global evaluation ceiling was already exhausted;
cluster order now rotates across cycles and a cluster cursor advances only after real consideration (or a genuinely empty page), preventing later-cluster starvation under the global evaluation ceiling.
exact worker-owned
deadline_exceededread failures now persist zero-counter Unknown/DurationLimit evidence instead of being misclassified as ordinary source failures; Kafka-native timeout codes remain source failures.rotating partitions now receive the full remaining policy byte capacity (bounded by the per-evaluation hard ceiling), avoiding permanent starvation of records larger than a proportional byte share.
empty byte-limited reads now retain the current partition as the next rotation cursor and stop that policy cycle, so the next cycle retries it first with the full policy allowance instead of wrapping back to an earlier partition.
empty byte-limited reads retain the current partition only when the attempt was temporarily underfunded below the full policy/server byte ceiling;
a full-ceiling oversized record rotates onward so later partitions are still monitored;
timestamp uncertainty no longer aborts inspection of the remaining already-bounded batch; later in-window records are evaluated while evidence remains partial.
rebased onto protected-main
cb2519bc853ed21da5b3e310530c6d062324ca20after W67 Slice 3 admission;permanently oversized full-ceiling reads persist their returned continuation offset and resume beyond the blocked record on later cycles;
stale resume offsets are discarded without fabricating source failures, returning later cycles to timestamp-window resolution.
rebased onto protected-main
67edb7950d09020bbb03e5441df932ce7b0f0a0fafter W66 webhook runtime admission;policy rate limits are now enforced by a rolling one-second ledger shared across partitions and immediate cycles;
concurrent cycles on the same worker are serialized so they cannot double-spend the same rate allowance;
resumed reads advance their continuation on truncated success and clear it on completion.
regression expectations were aligned with the admitted rolling-rate semantics: immediate cycles do not receive fresh per-policy allowance; fairness is tested after the one-second rolling window releases capacity.
rolling rate history is keyed by stable policy identity so a definition/version replacement cannot reset the per-second allowance;
a retained resume that provably returns only timestamped records older than the current evaluation window is cleared and not persisted as a fresh window evaluation; subsequent cycles re-resolve from the timestamp window.
byte-limited empty reads now conservatively charge one attempted record and the entire remaining policy byte allowance for the rolling window;
truncated resumed reads advance from
LastReturnedOffset + 1when the adapter omitsNextAnchorat the captured high watermark.every successfully persisted truncated read now installs/advances continuation from evaluated progress, including initial timestamp-anchored reads;
continuation is bounded by source continuation and therefore never skips source-unread data;
evaluator-returned cancellation is propagated before durable evidence persistence.
rebased without semantic changes onto protected-main
51d9c109f2c9a6fb429e8638a5dd9ba321884ac3, whose only intervening changes were workflow action pin updates.rebased without semantic changes onto latest protected-main
5379d824661928770a00f6b3f7861ff18b6b0e14after Dependabot PR chore(deps): Bump @tabler/core from 1.5.1 to 1.6.1 in /src/frontend #259 (@tabler/core 1.6.1); W65 files are unchanged semantically.timestamp-uncertain records advance continuation only across a safely inspected prefix before the first accepted record; a fully filtered bounded page therefore progresses, while accepted but unevaluated records are never skipped.
worker-owned
deadline_exceededreads now conservatively charge the current read budget against the rolling policy allowance before persisting Unknown/DurationLimit evidence;source truncation no longer overwrites an evaluator outcome that already stopped earlier for Duration/Record/Byte limits.
source truncation is now applied only after every admitted record was actually evaluated; if the evaluator stopped earlier, its limiting outcome is preserved.