Skip to content

fix(data-quality): close W65 authorization and UI gaps - #262

Merged
akhiabanchian merged 8 commits into
mainfrom
w65-api-ui-closeout-corrective
Oct 7, 2026
Merged

akhiabanchian merged 8 commits into
mainfrom
w65-api-ui-closeout-corrective

Conversation

@ammarheidari

Copy link
Copy Markdown
Contributor

W65 final corrective / closeout

Follow-up to merged PR #261. Three P1 findings landed immediately after that merge, so W65 #214 remained open.

Security corrections

  • authorization-filtered list pagination never serializes a hidden policy ID as the continuation cursor;
  • historical evidence is filtered against TopicRead for each point's actual topic, with bounded denial audit;
  • replace/state mutations require ExpectedRevision to equal the exact snapshot revision whose topic was authorized, closing the future-revision CAS race;
  • existing policy/topic/cluster authorization conjunction remains fail-closed.

Operator UI parity

  • bounded policy list/detail;
  • aggregate evidence view with explicit Available/Partial/Unknown/Unavailable truth;
  • authorization-filtered/truncated states are surfaced explicitly;
  • create/replace through revision-guarded policy JSON;
  • lifecycle state transitions use exact revision CAS;
  • HTTP 409 refreshes state and never silently retries an overwrite;
  • no polling/WebSocket loop;
  • no raw Kafka key/value/header/payload surface.

Regression evidence

  • backend architecture test locks all three post-merge security correctives;
  • frontend tests lock bounded UI, no polling/raw-payload surface and safe-cursor behavior.

W65 #214 closes only after this exact head is admitted to protected main and tracker #209 is reconciled.

Refs #214 #209.

Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head 85aaccef08aae2a449d13d00b5f37cec25a084fb only. Verify all three post-merge W65 P1 findings are fully closed: hidden policy IDs cannot escape through pagination cursors, historical evidence enforces TopicRead against every point's actual topic, and lifecycle mutations bind authorization to the exact CAS revision. Also verify UI parity remains bounded, aggregate-only, conflict-refresh/no-overwrite, and introduces no polling, raw payload or authorization bypass.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T18:59:27.382723Z 9c86759 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

akhiabanchian
akhiabanchian previously approved these changes Oct 7, 2026
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>

Copy link
Copy Markdown
Contributor Author

@codex review

Please review corrective exact head 9c867592f7b53bbe584b5bc684305502a4a48fc0 only. The only delta after the prior reviewed head is a strict TypeScript-safe duration parser guard in DataQualityPanel. Re-verify the three W65 P1 security fixes, bounded UI parity, no raw payload/polling, and no implicit CAS overwrite.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 9c867592f7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@akhiabanchian
akhiabanchian merged commit dd7c546 into main Oct 7, 2026
8 checks passed
@akhiabanchian
akhiabanchian deleted the w65-api-ui-closeout-corrective branch October 7, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants