Skip to content

🛡️ Sentinel: [MEDIUM] Add explicit timeouts to external fetch calls - #27

Open
felirami wants to merge 1 commit into
mainfrom
sentinel-fetch-timeouts-1152957282951708902
Open

felirami wants to merge 1 commit into
mainfrom
sentinel-fetch-timeouts-1152957282951708902

Conversation

@felirami

@felirami felirami commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

User description

🚨 Severity: MEDIUM
💡 Vulnerability: Unbounded external fetch calls. The native fetch API does not have a default timeout.
🎯 Impact: If an external service hangs or responds very slowly, the Next.js server resources (connections, memory) can be exhausted waiting for the request to complete, leading to a Denial of Service (DoS) condition.
🔧 Fix: Added signal: AbortSignal.timeout(TIMEOUT_MS) to the external fetch calls in getNetworkStatus (src/lib/network.ts) and getSnapMarketData (src/lib/snap-market.ts). Appended the finding to the .jules/sentinel.md journal.
Verification: Ran npm run lint, npm run typecheck, and npm run build locally to verify the build succeeds and types pass without errors.


PR created automatically by Jules for task 1152957282951708902 started by @felirami


Note

Low Risk
Small, defensive change to outbound HTTP; existing error handling should surface timeouts without altering success paths.

Overview
Adds 10s abort signals to server-side fetch calls that previously could hang indefinitely: the public node info probe in getNetworkStatus and the Dexscreener request in getSnapMarketData.

Documents the pattern in .jules/sentinel.md (unbounded native fetch → DoS/resource exhaustion) and recommends AbortSignal.timeout() for external requests.

Reviewed by Cursor Bugbot for commit 2392b21. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Prevent hanging external requests from tying up the server

What Changed

  • External API requests now stop after a short timeout instead of waiting indefinitely.
  • The node status check and Snap market data lookup will fail fast when a remote service is slow or unresponsive.
  • The security note now records the risk of unbounded fetch calls and the timeout pattern to use going forward.

Impact

✅ Fewer server hangs from slow external services
✅ Lower risk of request-related resource exhaustion
✅ Faster recovery when third-party APIs stop responding

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Note

Add explicit timeouts to external fetch calls in network and market data checks

  • Adds AbortSignal.timeout(NODE_PROBE_TIMEOUT_MS) to the fetch in getNetworkStatus so network probes abort instead of hanging indefinitely.
  • Adds a DEXSCREENER_TIMEOUT_MS constant (10 seconds) and applies it to the fetch in getSnapMarketData, returning ok: false on timeout via the existing catch path.
  • Behavioral Change: both functions now return error results sooner on slow or unresponsive endpoints rather than waiting indefinitely.

Macroscope summarized 2392b21.

Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hypersnaporg Ready Ready Preview, Comment Jun 21, 2026 8:55pm

Request Review

@codeant-ai

codeant-ai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jun 21, 2026

This branch was successfully deployed

1 active deployment
Preview 2392b219 Deployed Jun 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant