Fix magproj docs/code mismatch and integrate magMWdust from PR #19 - #20
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job R-CMD-check on macOS-latest
Fix magproj docs/code mismatch and integrate magMWdust from PR #19
Jul 29, 2026
asgr
marked this pull request as ready for review
July 29, 2026 06:22
Owner
|
Note to fix some issues copilot had to copy across the original pull request from @AngusWright. I was a bit confused by this, but I think the issue is it could only make direct edits to pull requests launched by me or it. I've been sure to leave the relevant credit in the magMWdust files though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #19 added a
lab.cex=1parameter tomagproj()but omitted it fromman/magproj.Rd, causingR CMD checkto fail with a codoc WARNING. This also incorporates the full feature set from PR #19.Changes
Documentation fix (root cause of CI failure)
man/magproj.Rd— Addedlab.cex = 1to\usage{}and a new\item{lab.cex}entry in\arguments{}magproj()code changes (from PR #19)R/magproj.R— Addedlab.cex=1parameter; passes it ascexto all internaltext()label calls; replaced the naivelat= (lat+90) %% 180 - 90wrap with a proper.lat_wrap()helper that correctly handles polar boundary casesNew
magMWdustfunction (from PR #19)R/magMWdust.R— Plots SFD MW dust as projected points or polygons, with opacity scaled viamagmap(); includesutils::globalVariables("SFD_dust")to suppress the NOTE for the lazy-loaded datasetman/magMWdust.Rd— Full documentation formagMWdustand theSFD_dustdataset aliasdata/SFD_dust.rda— 1×1 deg equatorial-grid SFD dust lookup table (~295 KB)Package metadata
DESCRIPTION— AddedLazyData: trueto enable lazy-loading ofSFD_dustNAMESPACE— AddedsetTxtProgressBarandtxtProgressBartoutilsimports