Skip to content

Fix magproj docs/code mismatch and integrate magMWdust from PR #19 - #20

Merged
asgr merged 3 commits into
masterfrom
copilot/fix-github-actions-job
Jul 29, 2026
Merged

Fix magproj docs/code mismatch and integrate magMWdust from PR #19#20
asgr merged 3 commits into
masterfrom
copilot/fix-github-actions-job

Conversation

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

PR #19 added a lab.cex=1 parameter to magproj() but omitted it from man/magproj.Rd, causing R CMD check to fail with a codoc WARNING. This also incorporates the full feature set from PR #19.

Changes

Documentation fix (root cause of CI failure)

  • man/magproj.Rd — Added lab.cex = 1 to \usage{} and a new \item{lab.cex} entry in \arguments{}

magproj() code changes (from PR #19)

  • R/magproj.R — Added lab.cex=1 parameter; passes it as cex to all internal text() label calls; replaced the naive lat= (lat+90) %% 180 - 90 wrap with a proper .lat_wrap() helper that correctly handles polar boundary cases

New magMWdust function (from PR #19)

  • R/magMWdust.R — Plots SFD MW dust as projected points or polygons, with opacity scaled via magmap(); includes utils::globalVariables("SFD_dust") to suppress the NOTE for the lazy-loaded dataset
  • man/magMWdust.Rd — Full documentation for magMWdust and the SFD_dust dataset alias
  • data/SFD_dust.rda — 1×1 deg equatorial-grid SFD dust lookup table (~295 KB)

Package metadata

  • DESCRIPTION — Added LazyData: true to enable lazy-loading of SFD_dust
  • NAMESPACE — Added setTxtProgressBar and txtProgressBar to utils imports

Copilot AI changed the title [WIP] Fix failing GitHub Actions job R-CMD-check on macOS-latest Fix magproj docs/code mismatch and integrate magMWdust from PR #19 Jul 29, 2026
Copilot AI requested a review from asgr July 29, 2026 06:09
Copilot finished work on behalf of asgr July 29, 2026 06:09
@asgr
asgr marked this pull request as ready for review July 29, 2026 06:22
Copilot AI review requested due to automatic review settings July 29, 2026 06:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@asgr
asgr merged commit 0ceb832 into master Jul 29, 2026
3 checks passed
@asgr

asgr commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Note to fix some issues copilot had to copy across the original pull request from @AngusWright. I was a bit confused by this, but I think the issue is it could only make direct edits to pull requests launched by me or it. I've been sure to leave the relevant credit in the magMWdust files though.

@asgr
asgr deleted the copilot/fix-github-actions-job branch July 29, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants