Skip to content

Pin bump: let the bump job run 45 minutes - #215

Merged
askalf merged 1 commit into
mainfrom
pin-bump-time
Nov 13, 2026
Merged

askalf merged 1 commit into
mainfrom
pin-bump-time

Conversation

@askalf

@askalf askalf commented Nov 13, 2026

Copy link
Copy Markdown
Owner

The bump job in redline-pin-bump.yml had a 30-minute limit. A dispatch without wait-for-quiet bumps every caller in one run at about 70 s each, and pin-bump.test.mjs asks for 1.25x room: twenty callers need 1750 s of 1800 s, so the next caller added would not fit.

  • timeout-minutes 30 to 45, which covers thirty callers.
  • A new check in scripts/redline/pin-bump.test.mjs: the limit stays under an hour, since the App token the job mints lasts an hour and a longer run would outlive it.
  • CHANGELOG entry.

node scripts/redline/pin-bump.test.mjs: 50 pass, 0 fail.

Twenty callers at the measured 70 s each, with 1.25x room, need 1750 s
of the 1800 s limit, so the next caller would not fit. 45 minutes covers
thirty. The test also fails a limit of an hour or more, since the App
token the job mints lasts an hour.

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: approve. The 45-minute limit accommodates thirty callers at the test's assumed rate and headroom while remaining below the App token's lifetime. The added assertion enforces that upper bound, and the workflow comments and changelog match the configuration.

@askalf
askalf merged commit c243228 into main Nov 13, 2026
13 checks passed
@askalf
askalf deleted the pin-bump-time branch November 13, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants