Repository navigation
Pin bump: let the bump job run 45 minutes - #215
Merged
Merged
Conversation
Twenty callers at the measured 70 s each, with 1.25x room, need 1750 s of the 1800 s limit, so the next caller would not fit. 45 minutes covers thirty. The test also fails a limit of an hour or more, since the App token the job mints lasts an hour.
sprayberry-redline
approved these changes
Nov 13, 2026
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: approve. The 45-minute limit accommodates thirty callers at the test's assumed rate and headroom while remaining below the App token's lifetime. The added assertion enforces that upper bound, and the workflow comments and changelog match the configuration.
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bump job in
redline-pin-bump.ymlhad a 30-minute limit. A dispatch without wait-for-quiet bumps every caller in one run at about 70 s each, andpin-bump.test.mjsasks for 1.25x room: twenty callers need 1750 s of 1800 s, so the next caller added would not fit.timeout-minutes30 to 45, which covers thirty callers.scripts/redline/pin-bump.test.mjs: the limit stays under an hour, since the App token the job mints lasts an hour and a longer run would outlive it.node scripts/redline/pin-bump.test.mjs: 50 pass, 0 fail.