Repository navigation
fleet-status check: the evaluator reads own properties only - #219
Merged
Merged
Conversation
The fuzzer (run 43463587459) found `__proto__(...)` passing the function check through Object.prototype and throwing a TypeError, which the fuzz contract forbids: the evaluator returns a value or throws a plain Error. toString(), a context named constructor and paths like github.event.constructor reached Object.prototype the same way and read as built-ins where Actions has no such function, context or property. Every lookup by a name from the expression now checks own properties: an unknown function is a plain Error, a missing context or property null (or an Error under strict), and under trusted a github property the caller did not supply stays UNKNOWN. The fuzzer's crash input replays clean.
sprayberry-redline
approved these changes
Nov 13, 2026
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: approve. The evaluator now limits expression-derived function, context, matrix, and property lookups to own properties, preventing inherited JavaScript members from being invoked or read. The added coverage exercises inherited-name rejection, strict and trusted handling, and legitimate string and array properties.
This was referenced Nov 13, 2026
askalf
pushed a commit
to askalf/pitlane
that referenced
this pull request
Nov 14, 2026
Moves this repository's askalf/ci pins (its reusable workflow calls, their redline-ref inputs and any action pins) to askalf/ci@f0be701, the main commit that last changed the review, the fix or an action (main 2026-11-14, askalf/ci#219). The scripts are fetched at that same commit. The pins are the only change. --------- Co-authored-by: askalf-pin-bump[bot] <352119504+askalf-pin-bump[bot]@users.noreply.github.com>
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fuzz run on 2026-11-13 (run 43463587459) crashed
fuzz/workflow_check.fuzz.jswithTypeError: fns[k.v] is not a function. The input contained__proto__(...):fns[k.v]foundObject.prototypethrough__proto__, passed the unknown-function check, and was then called. The fuzz contract says the evaluator returns a value or throws a plain Error, never a TypeError from its own parser.The same lookup let
toString()andconstructor()run as JavaScript built-ins. A context namedconstructor(andk.v in ctxunder strict), amatrix.constructorkey, and paths likegithub.event.constructoralso reachedObject.prototype. GitHub Actions has no such function, context or property.Change (
scripts/fleet-status/check.mjs): oneown(o, key)helper (Object.hasOwnon the value) guards every lookup by a name taken from the expression:Error('unknown function …');unknown contextunder strict;Strings and arrays keep their own indexes and
length.Tests (
scripts/fleet-status/check.test.mjs): four new checks, 179 pass. Three of them fail on main. Replaying the fuzzer's saved crash input through the fuzz target is clean with the change and throws the same TypeError without it.