Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unsigned NumPy integers are currently classified as floats. This bypasses
intfmtand can lose precision: formattingnumpy.uint64(2**64 - 1)withfloatfmt=".0f"produces18446744073709551616instead of18446744073709551615.Recognize NumPy integer scalars by their integral type and integer dtype. The dtype check keeps NumPy durations out of the integer path, while the NumPy type restriction preserves the behavior of Python booleans, enums, and other values.
Regression tests cover signed and unsigned integer types and the
longlongaliases, comma and hexadecimal integer formats, and list, NumPy-array, and DataFrame inputs.Validation
git diff --checkpass.AI-assisted implementation and testing, with independent review by a separate AI agent. No human review is claimed.