Validate GNU build IDs in Linux artifacts - #1232
Merged
Merged
Conversation
Require executables and shared libraries to contain a nonempty GNU build ID to support debuginfod.
jjhelmus
added
platform:linux
EliteTK
approved these changes
Aug 25, 2026
EliteTK
left a comment
EliteTK
left a comment
Member
There was a problem hiding this comment.
This seems fine.
We could use object::read::Object::build_id here, but the current approach should work for our toolchains.
We do strip after this, and we don't check after that. Stripping shouldn't remove this but who knows...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require executables and shared libraries to contain a nonempty GNU build ID to support debuginfod.
Follow up to #1230