Skip to content

[ty] Test typeshed LiteralString change for JSON indentation - #28664

Closed
AlexWaygood wants to merge 1 commit into
mainfrom
alex/typeshed-json-indent-literalstring
Closed

AlexWaygood wants to merge 1 commit into
mainfrom
alex/typeshed-json-indent-literalstring

Conversation

@AlexWaygood

Copy link
Copy Markdown
Member

Cherry-pick python/typeshed#16402 into ty's vendored stubs to see the ecosystem impact.

@AlexWaygood AlexWaygood added the ty Multi-file analysis & type inference label Sep 17, 2026
@astral-sh-bot

astral-sh-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 97.85%. The percentage of expected errors that received a diagnostic held steady at 96.99%. The number of fully passing files held steady at 130/145.

@astral-sh-bot

astral-sh-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

Lint rule Added Removed Changed
invalid-argument-type 9 0 1
Total 9 0 1

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Raw diff:

altair (https://github.com/vega/altair)
+ altair/vegalite/v6/api.py:2214:13 error[invalid-argument-type] Argument to function `dumps` is incorrect: Expected `None | int | LiteralString`, found `int | str | None`

jax (https://github.com/google/jax)
- jax/experimental/array_serialization/serialization_test.py:948:24 error[invalid-argument-type] Argument to class `partial` is incorrect: Expected `_SerializeAuxData`, found `def dumps(obj: Any, *, skipkeys: bool = False, ensure_ascii: bool = True, check_circular: bool = True, allow_nan: bool = True, cls: type[JSONEncoder] | None = None, indent: None | int | str = None, separators: tuple[str, str] | None = None, default: ((Any, /) -> Any) | None = None, sort_keys: bool = False, **kwds: Any) -> str`
+ jax/experimental/array_serialization/serialization_test.py:948:24 error[invalid-argument-type] Argument to class `partial` is incorrect: Expected `_SerializeAuxData`, found `def dumps(obj: Any, *, skipkeys: bool = False, ensure_ascii: bool = True, check_circular: bool = True, allow_nan: bool = True, cls: type[JSONEncoder] | None = None, indent: None | int | LiteralString = None, separators: tuple[str, str] | None = None, default: ((Any, /) -> Any) | None = None, sort_keys: bool = False, **kwds: Any) -> str`

openlibrary (https://github.com/internetarchive/openlibrary)
+ openlibrary/plugins/upstream/utils.py:287:26 error[invalid-argument-type] Argument to function `dumps` is incorrect: Expected `None | int | LiteralString`, found `int | str | None`
+ openlibrary/solr/utils.py:106:61 error[invalid-argument-type] Argument to function `dumps` is incorrect: Expected `None | int | LiteralString`, found `int | str | None`
+ openlibrary/solr/utils.py:108:58 error[invalid-argument-type] Argument to function `dumps` is incorrect: Expected `None | int | LiteralString`, found `int | str | None`

pip (https://github.com/pypa/pip)
+ src/pip/_vendor/rich/json.py:40:13 error[invalid-argument-type] Argument to function `dumps` is incorrect: Expected `None | int | LiteralString`, found `None | int | str`
+ src/pip/_vendor/rich/json.py:87:13 error[invalid-argument-type] Argument to function `dumps` is incorrect: Expected `None | int | LiteralString`, found `None | int | str`

pydantic (https://github.com/pydantic/pydantic)
+ pydantic/v1/error_wrappers.py:68:42 error[invalid-argument-type] Argument to function `dumps` is incorrect: Expected `None | int | LiteralString`, found `None | int | str`

rich (https://github.com/Textualize/rich)
+ rich/json.py:40:13 error[invalid-argument-type] Argument to function `dumps` is incorrect: Expected `None | int | LiteralString`, found `None | int | str`
+ rich/json.py:87:13 error[invalid-argument-type] Argument to function `dumps` is incorrect: Expected `None | int | LiteralString`, found `None | int | str`

Full report with detailed diff (timing results)

@AlexWaygood
AlexWaygood deleted the alex/typeshed-json-indent-literalstring branch September 17, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant