Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Seme30
left a comment
There was a problem hiding this comment.
Reviewed against the #820 P2 follow-ups. CI is green.
The Razor /reports and /groups missing-id tests match what was asked: OnGetAsync(null) returns PageResult with IsListView.
P2
-
#797still needs the collection case on the action, not only the full-view.loadProfileAnalyticsActionalready treatstype === "collection"like term (empty shell,error: nullwhen chart is missing).frontend/app/profile/actions.test.tsstill only has the term shell test. The newprofile-full-viewcases mock{ data: null, error: "not_found" }and assert the generic “Unable to load profile analytics” copy — that is the path the action is supposed not to take for term/collection. Please add a collection twin of the existing empty-shell action test. -
This PR and #828 both add the same
web.Tests/FunctionTests/Pages/Reports.Tests/Index.Tests.cs. Merge one first and rebase the other.
Not blocking the Razor list tests. Ready for team lead after the collection action test, or land as-is if you take that as a follow-up.
@Seme30 I've Addressed the #797 P2 follow-up:
Razor Re #828: both PRs include Ready for merge now. |
Summary
Follow-up for merged #820 (Razor/Next UI parity, #790–#797). Addresses Seme’s P2 review comments that were deferred to a post-merge PR:
/reportsand/groupswhen noidis provided (list view / missing-id path, 500-regression guard).#801 is out of scope — native
/users/settingsand API wiring were merged via #809 ondev.Changes
Frontend (
#797)profile-full-view.test.tsxnot_foundload-failure tests fortype="term"andtype="collection".Backend (Razor list regression)
web.Tests/FunctionTests/Pages/Reports.Tests/Index.Tests.cs—OnGetAsync_without_id_returns_list_viewweb.Tests/FunctionTests/Pages/Groups.Tests/Index.Tests.cs—OnGetAsync_without_id_returns_list_viewBoth assert
PageResult,IsListView == true, and list collections are non-null.Not included (already handled / coordination)
Test plan
npm run frontend:test -- --run frontend/components/profile/profile-full-view.test.tsxdotnet test web.Tests/web.Tests.csproj --filter "FullyQualifiedName~ReportsIndexTests|FullyQualifiedName~GroupsIndexTests"Related