Skip to content

test: #820 follow-up — #797 term/collection load failures and Razor reports/groups list tests - #825

Open
vbeni30 wants to merge 3 commits into
devfrom
fix/820-parity-review-followup
Open

vbeni30 wants to merge 3 commits into
devfrom
fix/820-parity-review-followup

Conversation

@vbeni30

@vbeni30 vbeni30 commented Sep 27, 2026

Copy link
Copy Markdown

Summary

Follow-up for merged #820 (Razor/Next UI parity, #790–#797). Addresses Seme’s P2 review comments that were deferred to a post-merge PR:

#801 is out of scope — native /users/settings and API wiring were merged via #809 on dev.

Changes

Frontend (#797)

  • profile-full-view.test.tsx
    • not_found load-failure tests for type="term" and type="collection".
    • Separate success tests for term and collection (replacing a single test that only rendered term).

Backend (Razor list regression)

  • web.Tests/FunctionTests/Pages/Reports.Tests/Index.Tests.cs — OnGetAsync_without_id_returns_list_view
  • web.Tests/FunctionTests/Pages/Groups.Tests/Index.Tests.cs — OnGetAsync_without_id_returns_list_view

Both assert PageResult, IsListView == true, and list collections are non-null.

Not included (already handled / coordination)

Item | Status -- | -- #801 /users/settings | Merged in #809 #808 settings commit overlap | Resolved on dev via #808 / #809 merges — no duplicate commits in this PR #796 / #804 default tab | #804 merged on dev — no duplicate change here

Test plan

  •  npm run frontend:test -- --run frontend/components/profile/profile-full-view.test.tsx
  •  dotnet test web.Tests/web.Tests.csproj --filter "FullyQualifiedName~ReportsIndexTests|FullyQualifiedName~GroupsIndexTests"
  •  CI green on this branch

Related

Comment thread frontend/Dockerfile Fixed
@vbeni30
vbeni30 changed the base branch from master to dev September 27, 2026 11:40
Co-authored-by: Cursor <cursoragent@cursor.com>

@Seme30 Seme30 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against the #820 P2 follow-ups. CI is green.

The Razor /reports and /groups missing-id tests match what was asked: OnGetAsync(null) returns PageResult with IsListView.

P2

  • #797 still needs the collection case on the action, not only the full-view. loadProfileAnalyticsAction already treats type === "collection" like term (empty shell, error: null when chart is missing). frontend/app/profile/actions.test.ts still only has the term shell test. The new profile-full-view cases mock { data: null, error: "not_found" } and assert the generic “Unable to load profile analytics” copy — that is the path the action is supposed not to take for term/collection. Please add a collection twin of the existing empty-shell action test.

  • This PR and #828 both add the same web.Tests/FunctionTests/Pages/Reports.Tests/Index.Tests.cs. Merge one first and rebase the other.

Not blocking the Razor list tests. Ready for team lead after the collection action test, or land as-is if you take that as a follow-up.

@Seme30 Seme30 mentioned this pull request Sep 28, 2026
7 tasks
@vbeni30

vbeni30 commented Sep 28, 2026

Copy link
Copy Markdown
Author

Reviewed against the #820 P2 follow-ups. CI is green.

The Razor /reports and /groups missing-id tests match what was asked: OnGetAsync(null) returns PageResult with IsListView.

P2

  • #797 still needs the collection case on the action, not only the full-view. loadProfileAnalyticsAction already treats type === "collection" like term (empty shell, error: null when chart is missing). frontend/app/profile/actions.test.ts still only has the term shell test. The new profile-full-view cases mock { data: null, error: "not_found" } and assert the generic “Unable to load profile analytics” copy — that is the path the action is supposed not to take for term/collection. Please add a collection twin of the existing empty-shell action test.
  • This PR and Fix/789 reports index #828 both add the same web.Tests/FunctionTests/Pages/Reports.Tests/Index.Tests.cs. Merge one first and rebase the other.

Not blocking the Razor list tests. Ready for team lead after the collection action test, or land as-is if you take that as a follow-up.

@Seme30 I've Addressed the #797 P2 follow-up:

  • Added loadProfileAnalyticsAction empty-shell test for type === "collection" (mirrors term).
  • Removed term/collection not_found UI tests that asserted the wrong path.

Razor /reports and /groups missing-id tests unchanged.

Re #828: both PRs include Reports.Tests/Index.Tests.cs. Happy to rebase whichever lands second and drop the duplicate, let me know merge order.

Ready for merge now.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants