docs: mark issued_supply a lifetime mint counter that burns never decrement - #14
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the AtomicAssets reference documentation to clarify that a template’s issued_supply is a lifetime mint counter and is not decremented by burnasset, meaning “circulating supply” must be derived separately (e.g., lifetime mints minus burns).
Changes:
- Clarifies
templates.issued_supplysemantics as lifetime mints (burns do not decrement it). - Expands
burnassetaction documentation to explicitly note it does not modify the parent template’sissued_supply. - Adds/extends primary-source citations to include
burnasset’s implementation reference.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| reference/atomicassets/tables.md | Documents issued_supply as a lifetime mint counter and cites burnasset to support “never decremented”. |
| reference/atomicassets/actions.md | Notes under burnasset that it does not change template issued_supply, framing how to compute circulating supply. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…rement An integrator computing a template's circulating count from issued_supply alone overcounts by the number of burns, and neither page said so. burnasset reads the template row only for the burnable check and writes nothing back, so the counter only ever moves up.
robrigo
force-pushed
the
docs/burn-keeps-issued-supply
branch
from
August 18, 2026 20:39
67bf1d1 to
7f9d039
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change claims, in one sentence:
burnassetnever decrements the parent template'sissued_supply, soissued_supplycounts lifetime mints and a circulating count must subtract burns.Source:
atomicassets-contractatv2.0.0-rc4:src/atomicassets.cpp:1096-1177(burnassetreads the template row only for theburnablecheck and writes nothing back); the only writes toissued_supplyin the tree aresrc/atomicassets.cpp:732(mintasset),:651(locktemplate), and:1615(template creation initializing it to 0).Tier: source-read.
Row in
validation-log.mdupdated: no; the rows forreference/atomicassets/actions.mdandreference/atomicassets/tables.mdalready carry this claim's exact primary source and tier (source-read at v2.0.0-rc4), and neither changes.