docs: state that no per-listing guard caps the execution-time collection fee - #15
Merged
Conversation
…ion fee The execution-time fee section warned that an author's fee change hits every open listing, but not that a seller has no counter to it: assertsale takes no fee parameter, so nothing can pin a maximum fee into a settlement transaction. The advisory previously lived only on a wiki page that was retired.
There was a problem hiding this comment.
Pull request overview
Updates the AtomicMarket fee/royalty documentation to explicitly state that sellers cannot set a per-listing guard (cap) on the execution-time collection fee, because assertsale does not accept any fee parameter—so UIs must compute expected seller proceeds using the live collection fee at settlement time.
Changes:
- Documented that no per-listing mechanism exists to cap execution-time collection fee exposure (ties directly to
assertsalehaving no fee field). - Expanded the section’s
Source:citation list to include theassertsalesignature locations. - Updated the corresponding
validation-log.mdentry to classify the newassertsalefact as source-read within a page tieredboth.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
reference/atomicmarket/fees-and-royalties.md |
Adds the explicit “no per-listing cap” statement and cites assertsale signature locations to support it. |
validation-log.md |
Updates the validation-log row notes to reflect that the new assertsale/no-cap claim is source-read evidence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change claims, in one sentence:
A seller has no per-listing cap against the execution-time collection fee:
assertsaleasserts asset ids, listing price, and settlement symbol, and takes no fee parameter, so a front end shows the live fee at the moment of sale.Source:
atomicmarket-contractatv2.0.0-rc2:src/atomicmarket.cpp:993-1015andinclude/atomicmarket.hpp:206(assertsaleparameter list, with no fee field); the execution-time application itself is already cited on the page atsrc/atomicmarket.cpp:2593-2609.Tier: source-read.
Row in
validation-log.mdupdated: yes; thereference/atomicmarket/fees-and-royalties.mdrow now notes theassertsalefact is source-read, since the page is tieredbothand its notes enumerate which facts the live run confirmed.