Skip to content

Can't import Saxs #19

Closed
Closed

Description

@PicoCentauri

When running from scatterkit import Saxs in a fresh env I get an error that the Q_SPACE_PARAMETERS is not available. This seems something we maybe removed from maicos... But the parameter should now live in the doc_dict of scatterkit...

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
    from scatterkit import Saxs
  File "/Users/philiploche/.venv/lib/python3.14/site-packages/scatterkit/__init__.py", line 6, in <module>
    from .diporderstructurefactor import DiporderStructureFactor
  File "/Users/philiploche/.venv/lib/python3.14/site-packages/scatterkit/diporderstructurefactor.py", line 21, in <module>
    @render_docs
     ^^^^^^^^^^^
  File "/Users/philiploche/.venv/lib/python3.14/site-packages/maicos/lib/util.py", line 303, in render_docs
    return _render_docs(func, doc_dict=DOC_DICT)
  File "/Users/philiploche/.venv/lib/python3.14/site-packages/maicos/lib/util.py", line 283, in _render_docs
    func.__doc__ = func.__doc__.replace(f"${{{key}}}", doc_dict[key])
                                                       ~~~~~~~~^^^^^
KeyError: 'Q_SPACE_PARAMETERS'

Activity

  1. PicoCentauri commented on Apr 23, 2026

    @PicoCentauri
    MemberAuthor

    Seems to work on the main branch. Maybe we should do a release @kjfisch

  2. hejamu commented on May 12, 2026

    @hejamu
    Member

    We should do a release: Two things:

    1. Why did our weekly test not catch this?
    2. Should be pin scatterkit and spectrakit releases to MAICoS releases? It's a bit more work at MAICoS release time but should be much more stable
  3. hejamu commented on May 12, 2026

    @hejamu
    Member

    Fixed by #21 and releasing v0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions