fix(classic): use generated packet command IDs - #265
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the stale numeric notification and map-stat command IDs in the Classic-target packet helpers with the generated Atrinik constants.
Implementation / behavior
Atrinik.CLIENT_CMD_NOTIFICATION.Atrinik.CLIENT_CMD_MAPSTATS.SendPacketreceiver.Validation
python3 tools/validate.pygit diff --checkLimitations / follow-up
Publication is gated on Classic #550 merging the generated constant exports. Native runtime qualification remains owned by Atrinik #604.
Closes #264
Delivery status
Classic #550 merged as
d926f6fd0418fb1af9060158c43d8d3ff5252580. The merged source exportsCLIENT_CMD_NOTIFICATION = 26andCLIENT_CMD_MAPSTATS = 12; its embedded-module tests and the content packet integration check pass at content head646c42dca71189b17b163eb4606e23cb5d0b8387. This satisfies the generated-constant publication prerequisite.Native runtime qualification remains owned by Atrinik #604.