Skip to content

feat(sdk): qualify the fixed portable LLVM release inventory - #62

Merged
zoeyrose merged 6 commits into
mainfrom
build/llvm-final-released-sdk-collector
Oct 13, 2026
Merged

zoeyrose merged 6 commits into
mainfrom
build/llvm-final-released-sdk-collector

Conversation

@zoeyrose

@zoeyrose zoeyrose commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Qualify the released portable Classic LLVM SDK through a fixed portable-final collector target for classic-portable-build:1.22.0. Bind producer eb1f6af78216adb4375826cdb70ef78a61ab403a, Classic consumer bd5317a03cdc82f029105c5dc26428b09fcd54b3, and the authenticated OCI index, Linux/amd64 manifest and config. Preserve all three historical 1.18.0 collector identities.

Implementation / behavior

The hosted collector acquires metadata and bytes through its existing unstarted container. The final path retains seven metadata hashes, all twelve LLVM roles, the three protected CMake/Ninja/pkgconf identities, source/provider archives, producer records, Debian notices and common licenses. It binds source and shader contracts to the exact consumer and rejects incomplete or changed archive/provider declarations.

A separate non-root, read-only, network-disabled scanner independently enumerates the installed filesystem through protected descriptor-relative reads. Acceptance requires exact agreement with all acquired inventories, metadata and tools, plus successful cleanup. Its explicit execution receipt remains separate from the acquisition container's installed-identity-only receipt.

Add exactly one final row and its workflow matrix entry. The row pins index sha256:74761e930f5d57face2d81efb0dc50dd4ce32ce1204810e56580bf68a5972ebc, platform manifest sha256:5e30957e54277bdaadeeffa42246258dc9df2086f3fb41f2125d041735ac72aa, and config sha256:c35dbeac2679d79dab524a13c9a3b74a8187878ecd3b3dff52bd2892418d7a79. An explicit three-name historical allowlist prevents a missing final policy from inheriting the historical producer fallback. Scanner cleanup accepts both stopped and already-stopped responses, then repeats the full exited-state ownership, image, command, mount and isolation fence before deletion. No caller image/path overrides or additional trusted workflow refs are introduced.

Validation

  • All 287 tooling tests and 66 portable tests passed with the reviewed umask 022 fixture environment. Retained evidence preserves the earlier inherited-umask failure and corrected baseline separately.
  • Final-row controls reject missing/malformed producer or consumer policy, wrong target package, and changed platform/config coordinates before container creation. Existing archive/provider, ownership, streamed-byte, scanner completeness, cleanup and network/credential isolation controls passed.
  • Real HTTP-response regressions reproduce the former cleanup race, accept stop responses 204/304, reject other statuses, and prevent deletion after ownership, image, isolation or state drift.
  • Actionlint passed for the changed hosted qualification workflow. Python compilation and whitespace checks passed; the final source commit is SSH-signed and the owned worktree is clean.
  • Prior independently reviewed collector foundations were replayed with signed -x commits onto the exact merged producer base. The actual 1.22.0 Linux release and five-image publication have separate authenticated self and independent acceptance receipts.
  • Independent integrated review is clear for final commit c0da037bf9ba7a02ae6f9406ea6e8fcc3e35d187. Current-commit Codex code and security reviews completed with no findings; the earlier scanner cleanup finding is fixed and its conversation resolved.
  • Hosted image CI passed on that exact commit: the shared LLVM source build, broad Linux, slim Classic CI, portable Classic, both Windows images and the complete native Windows test bundle. Required checks, Conventional PR title and CodeQL are green.

Limitations / follow-up

Source tests and release publication do not qualify installed inventories or filesystem equality. After merge, dispatch qualify-released-linux-sdk.yml on reviewed main, then authenticate and inspect both actual final-target receipts and retained artifacts before adopting wrapper metadata/inventory pins. A later semantic release from this collector change does not retarget the fixed 1.22.0 row.

Image Python, the producer OS and libraries remain trusted. This change does not establish wrapper export, physical GPU, gameplay, audible playback or legal completeness acceptance. Package acquisition and scanner execution remain confined to the hosted workflow; no local SDK pulls or image execution were used for this source change.

(cherry picked from commit 0b775f446e01cf36192f4440c63b3bfb82d5f81a)
(cherry picked from commit c5bd72cc7ca6cec777a538bbb07437470eb9910b)
(cherry picked from commit 9b757c7ff69e037961f0630fb6161005dc4c971d)
(cherry picked from commit 157999a1c39567b8a146eb5651c23be4a8f23f8b)
(cherry picked from commit 841a5034aa9d2a27a58e781759bd5c6f66674d0c)
(cherry picked from commit 16086e1b98e73eb0ea2a0b564ffa812bd49a61ff)
(cherry picked from commit c22f88ac8c5c0c8a712dcf453b50a30f574d02ad)
(cherry picked from commit e91e56c66b5cbc7494e69f338305c4caf9baeed9)
(cherry picked from commit 4ad7e3b33330e8ffed917491f48d113c7b599b2d)
(cherry picked from commit 66bf9220bf971b1712daa4696d60695e5be88148)
(cherry picked from commit dadfda7b3ff3632280f5c5ed543057d4e0f0300a)
(cherry picked from commit d1406ebac9774a67b1e5910fdc2c1714156f1103)
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Copy Markdown
Member Author

@codex review

Please review current commit 14159147e41b0e1935cc0d9661ac156a09bf7505, including the cumulative collector and filesystem scanner changes and the fixed released 1.22.0 target. Check acquisition versus execution claims, descriptor-bound inventories, isolation and cleanup, immutable OCI identities, and preservation of historical targets.

Copy link
Copy Markdown
Member Author

@codex security review

Please review current commit 14159147e41b0e1935cc0d9661ac156a09bf7505. Focus on trusted hosted dispatch, fixed image and source identities, credential separation, the separate non-root read-only filesystem scanner, ownership and source fences, bounded archive parsing, and cleanup after failures.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T13:31:20.647961Z c0da037 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-13T13:34:39.030000Z c0da037 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14159147e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/collect-released-sdk-metadata.py Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 14159147e4

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Copy link
Copy Markdown
Member Author

@codex review

Please review current commit c0da037bf9ba7a02ae6f9406ea6e8fcc3e35d187. The cleanup race is fixed with real HTTP304 regression coverage and full re-fencing before deletion. Review the cumulative collector/filesystem scanner implementation and fixed released SDK target for any remaining issues.

Copy link
Copy Markdown
Member Author

@codex security review

Please review current commit c0da037bf9ba7a02ae6f9406ea6e8fcc3e35d187, including the cleanup-race correction and retained ownership/isolation fences. The fixed release tuple, historical targets and trusted hosted workflow refs are unchanged.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: c0da037bf9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: c0da037bf9

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@zoeyrose
zoeyrose marked this pull request as ready for review October 13, 2026 13:27
@zoeyrose
zoeyrose merged commit 416505c into main Oct 13, 2026
21 checks passed
@zoeyrose
zoeyrose deleted the build/llvm-final-released-sdk-collector branch October 13, 2026 13:38
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant