Repository navigation
fix(sdk): retain bounded final inventory failure diagnostics - #63
Conversation
|
@codex review Please review current commit |
|
@codex security review Please review current commit |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a359c6fd1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review corrected current commit |
|
@codex security review Please review corrected current commit |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary
The first hosted collection of the fixed released portable LLVM SDK stopped before filesystem qualification and retained only a generic failure reason. Preserve a bounded validation code and local stage so the next reviewed-main run can identify the failing inventory check.
Implementation / behavior
Track nine fixed inventory stages. Retain an
InventoryErrorcode only when both the exception and its single string argument have exact built-in types and the code belongs to the source-defined allowlist. Unknown, hostile or unrelated exceptions remain opaque. Clear the stage after successful inventory collection. Include the diagnostics test in the collector workflow path filter, with a regression that requires every SDK boundary test selected by that workflow to have an explicit path entry.Keep the fixed SDK 1.22.0 producer, consumer and OCI identities, archive and provider validation, scanner isolation, byte comparisons and owned-container cleanup intact. Failure diagnostics do not establish inventory qualification.
Validation
All 357 isolated native tests passed: 291 tooling and 66 portable tests. Compilation,
git diff --check, commit signature and clean worktree checks passed. Independent review reproduced the suites and additional metadata, shader, hostile subclass and post-inventory failure cases with no blocking source findings.Hosted CI, current-head Codex Code and Security reviews, and automatic Ready reviews are required before merge.
Limitations / follow-up
Hosted collector run 38407172732 failed before the filesystem scan. It retained all 12 LLVM tool identities and successful acquisition cleanup, but its actual inventory failure cause remains unknown. This change adds diagnostics; it does not claim to fix or qualify that SDK. After merge, run one fresh trusted hosted collection and address its actual result. Wrapper adoption remains gated on successful acquisition and filesystem qualification.