Repository navigation
fix(sdk): fence root identity across Docker filesystem views - #64
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
|
@codex review Please review current commit |
|
@codex security review Please review current commit |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
🎉 This PR is included in version 1.25.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary
Docker opens a separate filesystem view for each container archive HEAD or GET. Its root-switching code creates and removes a temporary directory under
/, changing the root timestamp and potentially its directory storage size. Comparing those two fields across requests can reject an otherwise pristine, unstarted SDK acquisition container.Implementation / behavior
sizeandmtimeas view-local metadata; reject unknown root fields.The reviewed Docker implementation is container filesystem stat, separate archive request views, and root switching.
Validation
All 365 isolated source tests pass (299 tools and 66 portable). Changed Python syntax, actionlint, integrated diff checks and commit-signature verification pass. Root self-review and independent cumulative implementation review are clear. Source-derived differential checks reject root metadata churn on the prior collector and accept it on this revision, while negative ownership, schema, provider and isolation controls remain enforced. Required hosted image validation and current-head Codex code and security reviews must pass before merge.
Limitations / follow-up
The previous hosted collection reported
inventory-path-driftduring source-archive and provider checks, but did not retain the failing site or field. This change repairs a source-proven compatibility defect; it does not establish that defect as the observed cause of that run.After merge, collect the fixed released 1.22.0 SDK again on hosted CI. Successful acquisition and separate filesystem qualification are required before the workspace adopts its metadata and inventory pins. No released SDK identity is retargeted by this change.