Skip to content

fix(sdk): fence root identity across Docker filesystem views - #64

Merged
zoeyrose merged 2 commits into
mainfrom
fix/llvm-final-provider-path-stat
Oct 13, 2026
Merged

zoeyrose merged 2 commits into
mainfrom
fix/llvm-final-provider-path-stat

Conversation

@zoeyrose

Copy link
Copy Markdown
Member

Summary

Docker opens a separate filesystem view for each container archive HEAD or GET. Its root-switching code creates and removes a temporary directory under /, changing the root timestamp and potentially its directory storage size. Comparing those two fields across requests can reject an otherwise pristine, unstarted SDK acquisition container.

Implementation / behavior

  • Validate the exact known root-directory stat schema and compare its name, safe directory mode and empty link target across requests. Treat only validated root size and mtime as view-local metadata; reject unknown root fields.
  • Verify the bounded root tar header and UID 0 ownership before and after protected reads. Preserve full metadata comparisons for every non-root directory and file, immutable image and pristine container fences, actual byte hashes, independent filesystem scanning and owned cleanup.
  • Retain bounded failure diagnostics containing fixed comparison-site and subject labels plus changed known field names. Paths, values and unknown field names remain absent.

The reviewed Docker implementation is container filesystem stat, separate archive request views, and root switching.

Validation

All 365 isolated source tests pass (299 tools and 66 portable). Changed Python syntax, actionlint, integrated diff checks and commit-signature verification pass. Root self-review and independent cumulative implementation review are clear. Source-derived differential checks reject root metadata churn on the prior collector and accept it on this revision, while negative ownership, schema, provider and isolation controls remain enforced. Required hosted image validation and current-head Codex code and security reviews must pass before merge.

Limitations / follow-up

The previous hosted collection reported inventory-path-drift during source-archive and provider checks, but did not retain the failing site or field. This change repairs a source-proven compatibility defect; it does not establish that defect as the observed cause of that run.

After merge, collect the fixed released 1.22.0 SDK again on hosted CI. Successful acquisition and separate filesystem qualification are required before the workspace adopts its metadata and inventory pins. No released SDK identity is retargeted by this change.

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Copy Markdown
Member Author

@codex review

Please review current commit eb3596577f2095f5c8d954d889cd0902ed4f6c53, including the root-only stat comparison, repeated bounded ownership checks, failure diagnostics, nonroot/provider fences and adversarial regressions.

Copy link
Copy Markdown
Member Author

@codex security review

Please review current commit eb3596577f2095f5c8d954d889cd0902ed4f6c53 for security issues in the root-only metadata treatment, strict schema validation, repeated ownership checks, authenticated image/container fences and diagnostic redaction.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T22:46:50.645094Z eb35965 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-13T22:47:29.020527Z eb35965 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: eb3596577f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: eb3596577f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: eb3596577f

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: eb3596577f

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@zoeyrose
zoeyrose marked this pull request as ready for review October 13, 2026 22:43
@zoeyrose
zoeyrose merged commit 4a3c71c into main Oct 13, 2026
17 checks passed
@zoeyrose
zoeyrose deleted the fix/llvm-final-provider-path-stat branch October 13, 2026 22:49
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant