Skip to content

ADR-011: biofeedback egress (derived features over MIDI and OSC, health gated, off by default) #76

Open

Description

@aurascoper

What. Accept or amend docs/architecture/decision-log/ADR-011-biofeedback-egress.md and decision registry entry 10. The ADR makes BCIBiofeedback a scoped exception to "No network at runtime" alongside entries 8 (BCICloudBridge) and 9 (BCIPeerBridge), limited to EEG-derived features, with MIDI (in-machine) as default transport, OSC to loopback as default destination, LAN OSC as explicit choice, and raw EEG only through a named toggle.

Decisions to confirm before merging PR 1.

  • Loopback 127.0.0.1:7000 as the default OSC destination (matches Muse Port's default port).
  • holdLast as the default HealthPolicy.
  • MindMonitorMirror stays ungated by design (compatibility layer), with averageOverHealthyChannelsOnly defaulting to true.
  • Mind Monitor band edges reproduced exactly, including the 7.5 to 8 Hz theta/alpha overlap.
  • Raw /muse/eeg re-broadcast exists only as an explicit toggle.

Acceptance. ADR status moved from Proposed to Accepted and registry entry 10 updated to match. Updated CLAUDE.md first paragraph to read "No cloud. No telemetry. Network egress only through the three registered exceptions (registry entries 8, 9, and 10)."

Activity

  1. aurascoper commented on Nov 8, 2026

    @aurascoper
    OwnerAuthor

    Landed on main (bdfc4e9)

    • PR feat(biofeedback): BCIBiofeedback egress core (ADR-011) #77 (PR 1 - BCIBiofeedback egress core + ADR-011 Accepted): Merged (1c28d5a, commit d9c8d8a). 64/64 unit tests (BCIBiofeedbackTests + OSCEncoderTests).
    • PR feat(biofeedback): wire the egress into the app (ADR-011 PR 2) #78 (PR 2 - BiofeedbackCoordinator + BiofeedbackConfiguration + AppContainer/AppViewModel/PrivacyIndicatorView + Scripts/run-biofeedback-osc.sh): Rebased onto main and merged (7645e6b, commit 1431c45). 24/24 new tests (BiofeedbackCoordinatorTests + BiofeedbackConfigurationTests), 730/730 total tests green.
    • PR test(biofeedback): golden egress replay fixture and alpha physiology check (ADR-011 PR 5) #79 (PR 5 / Issue 6 - GoldenEgressReplayTests + MuseValidationAlphaTests + Fixtures/golden_egress_v1.json + Fixtures/muse_validation_alpha_v1.json + decision_registry.md Entry 10 replay evidence): Rebased onto main and merged (bdfc4e9, commit 898cd74). Explicitly marks muse_validation_20260710-004345 as overlapping segments (-12.19 s ring-buffer read-back jump, excluded from physiology claims) in Fixtures/README.md and MuseValidationAlphaTests.swift.

    Remaining items on this issue are the manual DAW/hardware checks (Issues 3 and 4) and the follow-up Mapping UI (Issue 5 / PR 4, including the 10-second healthy-window percentile range calibrator).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions