fix(deps): add @angular/build as explicit devDependency - #1059
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⛔ Files ignored due to path filters (1)
⚙️ Run configurationConfiguration used: Repository: auth0/auth0-angular/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: auth0/auth0-angular/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe package manifest now includes ChangesBuild Dependency
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The added development dependency is represented in the lockfile, so CI’s npm ci workflow has no dependency-sync blocker. No concrete merge-blocking risk is evidenced. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Prevents npm from de-hoisting @angular/build when Angular core and build-tool packages diverge in patch versions, causing @analogjs/vite-plugin-angular to fail loading @angular/build/private at vitest startup.
c351733 to
aba5325
Compare
Summary
@angular/buildas an explicitdevDependencyat^20.3.37(matching@angular-devkit/build-angularand@angular/cli)@angular/buildwhen Angular core packages and build-tool packages are at different patch versions@analogjs/vite-plugin-angularcannot resolve@angular/build/privateat vitest startup, causing CI to failContext
Closes the issue surfaced by dependabot PR #1057 where bumping
@angular/coreetc. to20.3.32caused npm to nest@angular/buildunder@angular-devkit/build-angularrather than hoisting it to the top level.Test plan
npm run test:ci)Summary by CodeRabbit