Skip to content

fix(deps): add @angular/build as explicit devDependency - #1059

Merged
yogeshchoudhary147 merged 1 commit into
mainfrom
fix/explicit-angular-build-dep
Sep 29, 2026
Merged

yogeshchoudhary147 merged 1 commit into
mainfrom
fix/explicit-angular-build-dep

Conversation

@yogeshchoudhary147

@yogeshchoudhary147 yogeshchoudhary147 commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds @angular/build as an explicit devDependency at ^20.3.37 (matching @angular-devkit/build-angular and @angular/cli)
  • Prevents npm from de-hoisting @angular/build when Angular core packages and build-tool packages are at different patch versions
  • Without this, @analogjs/vite-plugin-angular cannot resolve @angular/build/private at vitest startup, causing CI to fail

Context

Closes the issue surfaced by dependabot PR #1057 where bumping @angular/core etc. to 20.3.32 caused npm to nest @angular/build under @angular-devkit/build-angular rather than hoisting it to the top level.

Test plan

  • Unit tests pass (npm run test:ci)

Summary by CodeRabbit

  • Chores
    • Updated the development build setup. This change does not affect app functionality or the experience of using the app.

@yogeshchoudhary147
yogeshchoudhary147 requested a review from a team as a code owner September 28, 2026 03:38
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
⚙️ Run configuration

Configuration used: Repository: auth0/auth0-angular/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 92101f45-09a5-4a7d-ba19-2573e3d3d5f3

📥 Commits

Reviewing files that changed from the base of the PR and between c351733 and aba5325.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: auth0/auth0-angular/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 0c16563d-6863-417b-be49-3c1233618e1a

📥 Commits

Reviewing files that changed from the base of the PR and between 66d71a8 and c351733.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The package manifest now includes @angular/build version ^20.3.37 as a development dependency.

Changes

Build Dependency

Layer / File(s) Summary
Declare Angular build dependency
package.json
Adds @angular/build version ^20.3.37 to development dependencies.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: frederikprijck

Merge Risk: ⚪ Minimal · up to c3517

The added development dependency is represented in the lockfile, so CI’s npm ci workflow has no dependency-sync blocker. No concrete merge-blocking risk is evidenced.

Architecture Summary

Architecture risk: 🔵 Low · up to c3517

The change affects 1 system.

Changed systems: package.json

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — package.json (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in package.json: Added @angular/build as a development dependency with version range ^20.3.37.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding @angular/build as an explicit devDependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Prevents npm from de-hoisting @angular/build when Angular core and
build-tool packages diverge in patch versions, causing
@analogjs/vite-plugin-angular to fail loading @angular/build/private
at vitest startup.
@yogeshchoudhary147
yogeshchoudhary147 force-pushed the fix/explicit-angular-build-dep branch from c351733 to aba5325 Compare September 29, 2026 03:47
@yogeshchoudhary147
yogeshchoudhary147 merged commit 7111525 into main Sep 29, 2026
13 checks passed
@yogeshchoudhary147
yogeshchoudhary147 deleted the fix/explicit-angular-build-dep branch September 29, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants