Fix: Add NO_CONTENT and NOT_FOUND to GrantManagementAction - #4
Open
mharisjaved wants to merge 1 commit into
Open
Fix: Add NO_CONTENT and NOT_FOUND to GrantManagementAction#4mharisjaved wants to merge 1 commit into
mharisjaved wants to merge 1 commit into
Conversation
…dd regression tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authlete
/api/gmmay returnaction = "NO_CONTENT"(successful revoke; should map to HTTP 204)and
action = "NOT_FOUND"(grant not found / post-revoke; should map to HTTP 404).The Python SDK enum lacked these values, causing deserialization failures (e.g., KeyError) when
GrantManagementResponse.from_json()receives these actions.Changes
NO_CONTENTandNOT_FOUNDtoGrantManagementActiontests/dto/test_grant_management_response.pyReference
The Java SDK defines these actions in
GMResponse.Action(includesNO_CONTENT,NOT_FOUND):https://authlete.github.io/authlete-java-common/com/authlete/common/dto/GMResponse.html