Skip to content

fix(ticket-084): honor workspace comparison NL mode - #97

Merged
ifuri-validator-agent[bot] merged 3 commits into
mainfrom
fix/ticket-084-comparison-nl-mode
Aug 21, 2026
Merged

fix(ticket-084): honor workspace comparison NL mode#97
ifuri-validator-agent[bot] merged 3 commits into
mainfrom
fix/ticket-084-comparison-nl-mode

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Makes compare-workspace honor explicit --nl-mode and documents it. A deterministic task comparison now succeeds without provider credentials even when the ambient default is require-llm.\n\nValidation: npm verify 423 pass, 1 JDK-only skip; Docker smoke and governance pass.

@tom-sapletta-com
tom-sapletta-com force-pushed the fix/ticket-084-comparison-nl-mode branch from dabf884 to 8a29ac9 Compare August 21, 2026 21:18

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic Validator approval for exact head 8a29ac9b00f6c6135152eb2037623876a7f160ea.

Ticket: ticket-084
Correlation ID: todo2code-pr-97-ticket-084
Model: zai/glm-5.3
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Ticket-084 documentation and the CLI fix for compare-workspace honoring an explicit --nl-mode deterministic override. The command now constructs a command-scoped config with the parsed NL mode and passes it to the unchanged comparison API, matching the stated acceptance criteria. The extract dispatcher refactor is behavior-preserving delegation to per-command functions (continued in the next chunk). No failed checks in test results. | Chunk 2 refactors the t2c extract command dispatch from repeated if-blocks into per-extractor command functions behind a switch, preserving behavior. Help text now documents the explicit --nl-mode option for compare-workspace. A new integration test (test/cli-compare-workspace.test.ts) verifies deterministic NL mode works without credentials and that help exposes the new flag. All reported checks pass.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.

Decision record (recomputable)

DECISION D-084-1865
TICKET ticket-084
HEAD_SHA 8a29ac9b00f6c6135152eb2037623876a7f160ea
CORRELATION_ID todo2code-pr-97-ticket-084
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance=SKIPPING","Live OpenRouter contract (opt-in)=SKIPPING","verify=PASS","Java adapter (JDK 17 required)=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 72a6bd1 into main Aug 21, 2026
12 of 13 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the fix/ticket-084-comparison-nl-mode branch August 21, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant