Sprint_4 - #9
Open
avshushunov wants to merge 2 commits into
Open
Conversation
AlexKitIt
reviewed
Jun 17, 2026
| # напиши свои тесты ниже | ||
| # чтобы тесты были независимыми в каждом из них создавай отдельный экземпляр класса BooksCollector() No newline at end of file | ||
| def test_get_list_of_favorites_books_empty(self, collector): | ||
| assert collector.get_list_of_favorites_books() == [] No newline at end of file |
There was a problem hiding this comment.
Нужно исправить: проверять этот метод необходимо по заполненному списку
Owner
Author
There was a problem hiding this comment.
Исправлено: добавил тест с получением списка для метода get_list_of_favorites_books. Тест, что избранное пустое по умолчанию, оставил, как отдельную доп. проверку.
AlexKitIt
reviewed
Jun 17, 2026
| # напиши свои тесты ниже | ||
| # чтобы тесты были независимыми в каждом из них создавай отдельный экземпляр класса BooksCollector() No newline at end of file | ||
| def test_get_list_of_favorites_books_empty(self, collector): | ||
| assert collector.get_list_of_favorites_books() == [] No newline at end of file |
There was a problem hiding this comment.
Нужно исправить: отсутствуют тесты на проверку методов get_books_genre и get_book_genre. На каждый метод должен быть отдельный тест, вне зависимости, вызывается он в других тестах или нет
Owner
Author
There was a problem hiding this comment.
Исправлено: добавил в 2 теста для get_books_genre и get_book_genre.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.