You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Refactor] project add credentials payment does not match Connector regex #2533
project add credentials payment generates a credential name containing underscores, which the PaymentConnector ARN regex forbids, so a credential-backed payment connector can never deploy.
main (0.31.1) has a variant of this. add payment-connector builds the credential name as <manager>-<connector>-<suffix>, and connector names may contain underscores, so --name my_cdp produces the credential PayMgr-my_cdp-cdp. agentcore validate accepts it, and CreatePaymentCredentialProvider allows underscores in the name, but PaymentCredentialProviderConfiguration.credentialProviderArn only allows [a-zA-Z0-9-.]+ after paymentcredentialprovider/, so the connector can't reference it. Once you settle on the approach for refactor, I can port the same fix to main if that's useful.
@dfernaro you mentioned moving the fix to main once the approach for the refactor branch is settled. I can send a PR for the main variant (replace underscores with hyphens when add payment-connector builds the credential name, so --name my_cdp gives PayMgr-my-cdp-cdp) if you are not already on it. Are you working on it, or should I take it?
@musatoktas since I offered earlier, I went ahead and opened #2594 for the main variant. It replaces underscores with hyphens when add payment-connector builds the credential name, which keeps the .env.local variable names unchanged, and agentcore validate now flags existing underscored credential names with the name to rename them to.
Activity
dfernaro commentedon Oct 6, 2026
main(0.31.1) has a variant of this.add payment-connectorbuilds the credential name as<manager>-<connector>-<suffix>, and connector names may contain underscores, so--name my_cdpproduces the credentialPayMgr-my_cdp-cdp.agentcore validateaccepts it, andCreatePaymentCredentialProviderallows underscores in the name, butPaymentCredentialProviderConfiguration.credentialProviderArnonly allows[a-zA-Z0-9-.]+afterpaymentcredentialprovider/, so the connector can't reference it. Once you settle on the approach forrefactor, I can port the same fix tomainif that's useful.musatoktas commentedon Oct 14, 2026
@dfernaro you mentioned moving the fix to
mainonce the approach for the refactor branch is settled. I can send a PR for themainvariant (replace underscores with hyphens whenadd payment-connectorbuilds the credential name, so--name my_cdpgivesPayMgr-my-cdp-cdp) if you are not already on it. Are you working on it, or should I take it?dfernaro commentedon Oct 14, 2026
@musatoktas since I offered earlier, I went ahead and opened #2594 for the
mainvariant. It replaces underscores with hyphens whenadd payment-connectorbuilds the credential name, which keeps the.env.localvariable names unchanged, andagentcore validatenow flags existing underscored credential names with the name to rename them to.